Localize user-facing provider error messages (#4259)

Author: marcelveldt

music_assistant/providers/audiobookshelf/__init__.py

@@ -278,7 +278,11 @@ async def handle_async_init(self) -> None:
                 )
             await self._client_socket.init_client()
         except AbsLoginError as exc:
-            raise LoginFailed(f"Login to abs instance at {base_url} failed.") from exc
+            raise LoginFailed(
+                f"Login to abs instance at {base_url} failed.",
+                translation_key="provider.audiobookshelf.errors.login_failed",
+                translation_args=[base_url],
+            ) from exc
 
         if token_old is not None and token_api is None:
             # Log Message that the old token won't work

music_assistant/providers/audiobookshelf/strings.json

@@ -52,5 +52,8 @@
   },
   "manifest": {
     "description": "Stream audiobooks and podcasts from your personal Audiobookshelf server."
+  },
+  "errors": {
+    "login_failed": "Login to the Audiobookshelf server at {0} failed."
   }
 }

music_assistant/providers/chromecast/player.py

@@ -402,7 +402,9 @@ def launch() -> None:
         except TimeoutError:
             self.logger.warning("Timed out waiting for app launch on %s", self.display_name)
             raise PlayerUnavailableError(
-                f"Timed out launching app on {self.display_name}"
+                f"Timed out launching app on {self.display_name}",
+                translation_key="provider.chromecast.errors.app_launch_timeout",
+                translation_args=[self.display_name],
             ) from None
 
     ### Callbacks from Chromecast Statuslistener

music_assistant/providers/chromecast/strings.json

@@ -7,5 +7,8 @@
   },
   "manifest": {
     "description": "Cast music and podcasts to Chromecast or Google Cast devices."
+  },
+  "errors": {
+    "app_launch_timeout": "Timed out launching app on {0}."
   }
 }

music_assistant/providers/filesystem_local/__init__.py

@@ -230,7 +230,11 @@ async def handle_async_init(self) -> None:
         """Handle async initialization of the provider."""
         if not await isdir(self.base_path):
             msg = f"Music Directory {self.base_path} does not exist"
-            raise SetupFailedError(msg)
+            raise SetupFailedError(
+                msg,
+                translation_key="provider.filesystem_local.errors.music_directory_not_found",
+                translation_args=[self.base_path],
+            )
         await self.check_write_access()
 
     async def search(

music_assistant/providers/filesystem_local/strings.json

@@ -47,5 +47,8 @@
   },
   "manifest": {
     "description": "Play music and audiobooks stored on locally connected drives."
+  },
+  "errors": {
+    "music_directory_not_found": "Music directory {0} does not exist."
   }
 }

music_assistant/providers/filesystem_nfs/__init__.py

@@ -45,7 +45,11 @@ async def setup(
     server = str(config.get_value(CONF_HOST))
     if not await get_ip_from_host(server):
         msg = f"Unable to resolve {server}, make sure the address is resolvable."
-        raise SetupFailedError(msg)
+        raise SetupFailedError(
+            msg,
+            translation_key="provider.filesystem_nfs.errors.host_unresolvable",
+            translation_args=[server],
+        )
     # check if export path is valid
     export_path = str(config.get_value(CONF_EXPORT_PATH))
     if not export_path or not export_path.startswith("/") or not is_safe_path(export_path):

music_assistant/providers/filesystem_nfs/strings.json

@@ -26,5 +26,8 @@
   },
   "manifest": {
     "description": "Play music and audiobooks stored on NFS connected network drives."
+  },
+  "errors": {
+    "host_unresolvable": "Unable to resolve {0}, make sure the address is resolvable."
   }
 }

music_assistant/providers/filesystem_smb/__init__.py

@@ -48,8 +48,12 @@ async def setup(
     # check if valid dns name is given for the host
     server = str(config.get_value(CONF_HOST))
     if not await get_ip_from_host(server):
-        msg = f"Unable to resolve {server}, make sure the address is resolveable."
-        raise LoginFailed(msg)
+        msg = f"Unable to resolve {server}, make sure the address is resolvable."
+        raise LoginFailed(
+            msg,
+            translation_key="provider.filesystem_smb.errors.unresolvable_host",
+            translation_args=[server],
+        )
     # check if share is valid
     share = str(config.get_value(CONF_SHARE))
     if not share or "/" in share or "\\" in share:

music_assistant/providers/filesystem_smb/strings.json

@@ -44,5 +44,8 @@
   },
   "manifest": {
     "description": "Play music and audiobooks stored on SMB connected network drives."
+  },
+  "errors": {
+    "unresolvable_host": "Unable to resolve {0}, make sure the address is resolvable."
   }
 }