Skip to content

Commit 5a4c364

Browse files
committed
Tag type:ignore as also unused-ignore to satisfy packages mypy
The Test Galaxy packages CI job runs mypy on each package's src/ in isolation (~418 files), where some imports referenced by the ignored arg/type errors aren't visible. mypy then flags the ignore itself as unused. The combined [type-abstract,unused-ignore] form keeps the broader 'make mypy' (2207 files) silent while letting the packaged-mypy treat the ignore as benign.
1 parent 28913ab commit 5a4c364

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/galaxy/app/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,8 +420,8 @@ def _init_tool_source_store(self) -> None:
420420
)
421421

422422
self.tool_source_store: Optional[ToolSourceStore] = self._register_singleton(
423-
ToolSourceStore, # type: ignore[type-abstract]
424-
build_tool_source_store(self.config, self.model.context), # type: ignore[arg-type]
423+
ToolSourceStore, # type: ignore[type-abstract,unused-ignore]
424+
build_tool_source_store(self.config, self.model.context), # type: ignore[arg-type,unused-ignore]
425425
)
426426
stats = self.tool_source_store.get_stats()
427427
tool_count = stats.get("count", 0)

0 commit comments

Comments
 (0)