Fix api_filter to allow UUIDs#159
Merged
FragmentedPacket merged 1 commit intonautobot:developfrom Aug 24, 2022
Merged
Conversation
glennmatthews
approved these changes
Aug 22, 2022
FragmentedPacket
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing code, trying to filter by
idleads to theidbeing turned into anint. However, UUIDs are actually non-integer strings, so, if anything, we should be checking that the value is a UUID.However, I simply removed the checking entirely to preserve the behaviour of the example lookup with id=1 from the forked Netbox code.
As a result of the change, the original behaviour should be preserved as well as supporting this type of use: