Remove q query for VC.#32
Merged
FragmentedPacket merged 3 commits intonautobot:developfrom Apr 8, 2021
FragmentedPacket:30-vc-replace-bug
Merged
Remove q query for VC.#32FragmentedPacket merged 3 commits intonautobot:developfrom FragmentedPacket:30-vc-replace-bug
FragmentedPacket merged 3 commits intonautobot:developfrom
FragmentedPacket:30-vc-replace-bug
Conversation
jvanderaa
previously approved these changes
Apr 8, 2021
Contributor
|
@FragmentedPacket once the tests are passing confirmed that it will create them idempotently.
|
Contributor
|
However state of absent is failing. |
Contributor
Author
|
Ok. I'll check that once I'm back online |
Contributor
|
Ok, I checked against a B3 image. This is working properly. There may have been an issue where a space was also included as I re-ran the tests. So this is working with the latest versions. |
Contributor
Author
|
Both present and absent? |
Contributor
|
Yes. |
Contributor
|
So I think it was either the b1 instance, or the space that was on the one unit that had issues. That may be something else that we should look into eventually. |
Contributor
Author
|
@jvanderaa Tests are passing now :) |
jvanderaa
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30