Skip to content

Adds VM Interface Role.#415

Merged
joewesch merged 22 commits intodevelopfrom
vminterface_role
Sep 9, 2024
Merged

Adds VM Interface Role.#415
joewesch merged 22 commits intodevelopfrom
vminterface_role

Conversation

@jvanderaa
Copy link
Copy Markdown
Contributor

@jvanderaa jvanderaa commented Aug 25, 2024

Fixes #402

  • Adds the ability to use role on VM Interface
  • Updates tests

joewesch
joewesch reviewed Aug 27, 2024
View reviewed changes
Comment thread tests/integration/targets/latest/tasks/vm_interface.yml Outdated
@jvanderaa @joewesch
Update tests/integration/targets/latest/tasks/vm_interface.yml
44d7ba7 
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
joewesch
joewesch reviewed Aug 28, 2024
View reviewed changes
Comment thread tests/integration/nautobot-populate.py Outdated
joewesch
joewesch reviewed Aug 28, 2024
View reviewed changes
Comment thread tasks.py Outdated
Comment thread tests/integration/targets/latest/tasks/main.yml Outdated
Comment thread tests/integration/targets/latest/tasks/vm_interface.yml Outdated
joewesch
joewesch reviewed Aug 29, 2024
View reviewed changes
Comment thread tests/integration/nautobot-populate.py Outdated
@jvanderaa @joewesch
Update tests/integration/nautobot-populate.py
a604b69 
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
joewesch
joewesch previously approved these changes Aug 30, 2024
View reviewed changes
Comment thread tests/integration/nautobot-populate.py Outdated
jvanderaa and others added 2 commits September 3, 2024 09:21
@jvanderaa @joewesch
Update tests/integration/nautobot-populate.py
b09b641 
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
@joewesch
Merge branch 'develop' of github.com:nautobot/nautobot-ansible into v…
775d597 
…minterface_role
joewesch
joewesch approved these changes Sep 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@joewesch joewesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full tests pass: https://github.com/nautobot/nautobot-ansible/actions/runs/10686731124

@joewesch joewesch merged commit d107a00 into develop Sep 9, 2024
@joewesch joewesch deleted the vminterface_role branch December 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joewesch joewesch joewesch approved these changes

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Field: vminterface.role

2 participants

@jvanderaa @joewesch
⚡