Commit 3c2dbc7
authored
Bugfix/bestillingsstatus issues (#4221)
* - Refactor BestillingStatusMappingStrategy to improve bestilling status mapping logic
- Introduce UtledFagsystemResolver for determining relevant systems based on BestilteKriterier
- Enhance error handling for JSON parsing in bestilling status mapping
- Add utility methods for extracting bestilling criteria JSON and resolving systems
#deploy-test-dolly-backend
* - Handle errors in deployOrganisasjon by setting bestilling feil status
- Rename UtledFagsystemResolver to UtledFagsystemUtil for consistency
- Improve error logging in OrganisasjonController during gjenopprett process
#deploy-test-dolly-backend
* - Update deployOrganisasjon error handling to log errors and set bestilling feil status
- Refactor gjenopprett method in OrganisasjonController for improved readability and error handling
#deploy-test-dolly-backend
* - Add brukerId to the bestilling creation process in OrganisasjonBestillingService
#deploy-test-dolly-backend
* - Deploy dev
#deploy-test-dolly-backend
* - Refactor BestillingProgresjon to use sorted status list instead of merged status
- Simplify status handling in BestillingStatus by using statuser directly
- Remove unused getExpectedFagsystemer and mergeStatusWithExpected functions from fagsystemUtils
- Optimize manglerFagsystemdata checks in PersonVisning for better readability
#deploy-test-dolly-frontend
* - Deploy backend
#deploy-test-dolly-backend
* - Refactor tests in calculateProgress to use a consistent statusList variable
- Update polling interval in useVersionCheck from 60 seconds to 2 minutes
#deploy-test-dolly-frontend
* - Add UtledFagsystemUtilTest to cover various scenarios for resolving system types
- Implement tests for BestilteKriterier and their interactions with different data types
- Ensure no duplicates in resolved system types
#deploy-test-dolly-backend
* - Refactor GjenopprettBestilling to improve organization of imports and variable naming
- Update submitForm to utilize global mutate for handling new bestilling data
- Enhance logic for handling erOrganisasjon condition in submitForm
#deploy-test-dolly-frontend
* - Simplify title assignment logic in BestillingProgresjon component
- Refactor filtrerNyeBestillinger to improve readability and performance in StatusListe component
- Update onFinishBestilling and lukkBestilling to use functional state updates for better state management
- Change key prop in ikkeFerdig mapping to use bestilling.id for uniqueness
- Add 'enhetstype' to the list of valid environments in MiljoVelger
- Remove unnecessary initial loading checks in useOrgBestillingStream
#deploy-test-dolly-frontend
* - Deploy backend
#deploy-test-dolly-backend
* - Add sorting functionality for status lists in UtledFagsystemUtil
- Implement priority order for system types in fagsystemUtils
- Update BestillingProgresjon to include finished and stopped flags in onFinishBestilling callback
#deploy-test-dolly-backend
* - Deploy
#deploy-test-dolly-frontend
* - Update logic for adding new orders in GjenopprettBestilling component to prevent duplicates
- Ensure new orders are only added if they do not already exist in the current list
#deploy-test-dolly-frontend
* - Update bestillingStatusMapper to handle potential undefined values in system statuser
- Ensure flatMap safely processes statuser by providing a fallback to an empty array
#deploy-test-dolly-frontend
* - Deploy
#deploy-test-dolly-frontend
* - Refactor deployment logic in OrganisasjonClient to streamline error handling
- Replace nested subscription with a more concise chaining approach for better readability
#deploy-test-dolly-backend
* - Update BestillingController to format status output with detailed messages for each status
- Modify UtledFagsystemUtil to include additional condition for removing PDL_FORVALTER based on new identifier checks
#deploy-test-dolly-backend
* Deploy
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
* BestillingStatus fix
#deploy-test-dolly-backend
* BestillingStatus fix v2
#deploy-test-dolly-backend
* BestillingStatus fix v2
#deploy-test-dolly-frontend
* Fix missing newline at end of file in application starter classes
#deploy-test-dolly-frontend
#deploy-test-dolly-backend
* Refactor BestillingController and UtledFagsystemUtil to use nonNull and isNotBlank checks
* Deploy
#deploy-test-dolly-backend
* Fix BestillingStatus to correctly handle antallIdenter for organizations
#deploy-test-dolly-frontend
* Fix: Add missing newline at end of file in application starter classes
#deploy-test-dolly-frontend
#deploy-test-dolly-backend
* Deploy
#deploy-test-dolly-frontend
#deploy-test-dolly-backend
* Fix: Add support for resolving derived systems in Bestilling and related services
#deploy-test-dolly-backend
* Fix: Update BestillingController and BestillingService to use new method for fetching Bestilling with derived systems
- Refactor fetchBestillingById calls to fetchBestillingByIdMedUtlededeFagsystemer in BestillingController
- Add fetchBestillingByIdMedUtlededeFagsystemer method in BestillingService for better handling of derived systems
#deploy-test-dolly-backend
* Fix: Update BestillingStatus to handle derived system cases
- Introduce isGjenopprett flag to determine if the bestilling is derived
- Adjust logic to conditionally display antallBestilteIdenter based on isGjenopprett
- Update rendering of identer count to reflect derived system status
#deploy-test-dolly-frontend
* - Deploy
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
#deploy-dolly-proxy
* - Deploy
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
#deploy-dolly-proxy
* - Update BestillingServiceTest to mock new repository methods for fetching Bestillinger by Ident and GruppeId.
- Refactor BestillingStatus component to filter out transient status messages from the display.
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
* - Fix: Update logic in UtledFagsystemUtil to correctly add PDLIMPORT when restoring a Bestilling.
- Refactor: Remove unused filterImportSubSteps function from fagsystemUtils.ts and simplify sorting logic.
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
* - Refactor: Adjust formatting in calculateProgress.test.ts for consistency
- Refactor: Update fagsystemUtils.ts for improved readability and maintainability
- Enhance: Ensure filterImportSubSteps correctly filters based on PDLIMPORT presence
#deploy-test-dolly-frontend
* - Refactor: Remove unused filterImportSubSteps function from fagsystemUtils.ts
- Update: Export mapStatusrapport function in MiljoeStatus.tsx for better accessibility
- Fix: Adjust logic in BestillingStatus.tsx to correctly handle 'ferdig' status in conditional checks
- Clean up: Remove commented-out test cases for filterImportSubSteps in calculateProgress.test.ts
#deploy-test-dolly-frontend
* - Refactor: Simplify status icon logic in BestillingStatus component
- Enhance: Improve handling of OK and error statuses with new utility functions
- Update: Adjust rendering of status messages and identifiers for better clarity
#deploy-test-dolly-frontend
* Refactor: Improve formatting and structure in BestillingStatus component
- Standardize spacing and indentation for better readability
- Update rendering logic for status icons and messages
- Enhance error handling display for better user feedback
#deploy-test-dolly-frontend
* - Add PEN_FORVALTER to the list of constants in UtledFagsystemUtil
#deploy-test-dolly-backend
* - Update test description for sortFagsystemer to reflect functionality
- Refactor BestillingStatus component to use isErrorMessage for error handling
- Remove unused IN_PROGRESS_MESSAGES and simplify status checks in fagsystemUtils
#deploy-test-dolly-frontend
* - Changed progress text from 'Oppretter' to 'Opprettet' in calculateProgress.test.ts
- Update progress calculation logic to reflect correct values in fagsystemUtils.ts
#deploy-test-dolly-backend
#deploy-test-dolly-frontend
* - Add tests to ensure fagsystems are preserved during SSE events in useBestillingStream
- Implement logic to use final backend state on completion without placeholders
- Refactor error and warning message handling in BestillingStatus and related components
- Update bestillingHarFeil function to check for both error and warning messages
- Improve key assignment in TitleValue components for better rendering
#deploy-test-dolly-frontend
#deploy-test-dolly-backend
* - Update error message in BestillingStatus.tsx to use correct singular/plural form for 'ident'
#deploy-test-dolly-frontend
#deploy-test-dolly-backend1 parent 25e3046 commit 3c2dbc7
28 files changed
Lines changed: 1499 additions & 936 deletions
File tree
- apps
- dolly-backend/src
- dolly-frontend/src/main/js
- __tests__
- src
- components
- bestilling
- gjenopprett
- sammendrag/miljoeStatus
- statusListe
- BestillingProgresjon
- BestillingResultat
- fagsystem/inntektstub/bestilling
- miljoVelger
- ducks/bestillingStatus
- pages/gruppe/PersonVisning
- utils/hooks
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
90 | 93 | | |
91 | 94 | | |
92 | 95 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
| |||
apps/dolly-backend/src/main/java/no/nav/dolly/mapper/strategy/BestillingStatusMappingStrategy.java
Lines changed: 47 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
20 | 26 | | |
21 | 27 | | |
22 | 28 | | |
| |||
50 | 56 | | |
51 | 57 | | |
52 | 58 | | |
| 59 | + | |
53 | 60 | | |
54 | 61 | | |
55 | 62 | | |
| |||
67 | 74 | | |
68 | 75 | | |
69 | 76 | | |
| 77 | + | |
| 78 | + | |
70 | 79 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
| 80 | + | |
75 | 81 | | |
76 | 82 | | |
77 | 83 | | |
| |||
118 | 124 | | |
119 | 125 | | |
120 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
121 | 133 | | |
122 | 134 | | |
123 | 135 | | |
| |||
136 | 148 | | |
137 | 149 | | |
138 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
139 | 182 | | |
Lines changed: 11 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
147 | | - | |
| 149 | + | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
| |||
155 | 157 | | |
156 | 158 | | |
157 | 159 | | |
158 | | - | |
| 160 | + | |
159 | 161 | | |
160 | 162 | | |
161 | 163 | | |
| |||
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
167 | | - | |
| 169 | + | |
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| |||
181 | 183 | | |
182 | 184 | | |
183 | 185 | | |
184 | | - | |
185 | | - | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
186 | 192 | | |
187 | 193 | | |
188 | 194 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
0 commit comments