Skip to content

Commit 64e12f6

Browse files
committed
test: re-enable test_connect_stdio on Windows
Problem: test_connect_stdio was marked xfail on Windows since #544, but Neovim has since fixed stdio channel handling for detached processes on Windows (neovim/neovim#37977). Solution: Remove the xfail mark from test_connect_stdio. Keep xfail on test_connect_socket since it uses UNIX domain sockets which are fundamentally unsupported on Windows.
1 parent 38cbc4f commit 64e12f6

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/test_attach.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
# pylint: disable=redefined-outer-name
1919

2020

21-
xfail_on_windows = pytest.mark.xfail(
22-
"os.name == 'nt'", reason="Broken in Windows, see #544")
21+
_xfail_socket_on_windows = pytest.mark.xfail(
22+
"os.name == 'nt'", reason="UNIX sockets not supported on Windows, see #544")
2323

2424

2525
@pytest.fixture
@@ -36,7 +36,7 @@ def tmp_socket() -> Generator[str, None, None]:
3636
os.unlink(addr)
3737

3838

39-
@xfail_on_windows
39+
@_xfail_socket_on_windows
4040
def test_connect_socket(tmp_socket: str) -> None:
4141
"""Tests UNIX socket connection."""
4242
p = subprocess.Popen(["nvim", "--clean", "-n", "--headless",
@@ -91,7 +91,6 @@ def test_connect_tcp_no_server() -> None:
9191
pynvim.attach('tcp', address='127.0.0.1', port=port)
9292

9393

94-
@xfail_on_windows
9594
def test_connect_stdio(vim: Nvim) -> None:
9695
"""Tests stdio connection, using jobstart(..., {'rpc': v:true})."""
9796

0 commit comments

Comments
 (0)