Skip to content

Commit 56e10d7

Browse files
authored
Re-add treat warnings as errors (#1329)
* Re-add treat warnings as errors * Ops the comment was included * Fix warning
1 parent ba9e1e4 commit 56e10d7

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/ci_build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ jobs:
2727
run: echo "::add-matcher::.github/matchers/dotnet.json"
2828

2929
- name: 🛠️ Build code
30-
run: dotnet build --configuration Release
31-
# run: dotnet build --configuration Release -p:TreatWarningsAsErrors=true temprarily disabled due to Nuget bug
30+
# run: dotnet build --configuration Release
31+
run: dotnet build --configuration Release -p:TreatWarningsAsErrors=true
3232

3333
- name: 👀 Unit Test
3434
run: |

src/Runtime/NetDaemon.Runtime/Common/Extensions/ServiceCollectionExtensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public static IServiceCollection AddNetDaemonRuntime(this IServiceCollection ser
3030
/// Loads NetDaemon configuration section
3131
/// </summary>
3232
/// <param name="services">The <see cref="IServiceCollection" /> to add services to.</param>
33-
/// <param name="config">The current <see cref="IConfiguration" /> instance</param>
3433
/// <returns>The <see cref="IServiceCollection"/> so that additional calls can be chained.</returns>
3534
public static IServiceCollection ConfigureNetDaemonServices(this IServiceCollection services)
3635
{

0 commit comments

Comments
 (0)