fix: do not swallow error in fetchData#13058
Closed
longlho wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@longlho is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
This would introduce a breaking change, for codes that rely on |
Author
|
Understood. How do I override client fetching for next-auth provider? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
fetchDatacurrently swallows error, which makes network error returnsnulland is equivalent to a user becoming unauthenticated. I don't think that's ideal since a network blip can log a person out, especially in combination withrefetchIntervalthis has unintentional side effects.Downside is this makes session a bit stale.
🧢 Checklist
🎫 Affected issues
📌 Resources