Merge pull request #6062 from nextcloud/fix/groupfolder-share-object-storage

mejo- · web-flow · commit 6dfb01fa02de · 2024-07-02T10:53:08.000+02:00
Only check path for being accessible when the storage is a object home
diff --git a/lib/Sharing/DeckShareProvider.php b/lib/Sharing/DeckShareProvider.php
@@ -831,7 +831,7 @@ public function isAccessibleResult(array $data): bool {
 		$pathSections = explode('/', $data['path'], 2);
 		// FIXME: would not detect rare md5'd home storage case properly
 		if ($pathSections[0] !== 'files'
-			&& in_array(explode(':', $data['storage_string_id'], 2)[0], ['home', 'object'])) {
+			&& (strpos($data['storage_string_id'], 'home::') === 0 || strpos($data['storage_string_id'], 'object::user') === 0)) {
 			return false;
 		}
 		return true;

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,7 @@ public function isAccessibleResult(array $data): bool {`
`831`	`831`	`$pathSections = explode('/', $data['path'], 2);`
`832`	`832`	`// FIXME: would not detect rare md5'd home storage case properly`
`833`	`833`	`if ($pathSections[0] !== 'files'`
`834`		`- && in_array(explode(':', $data['storage_string_id'], 2)[0], ['home', 'object'])) {`
	`834`	`+ && (strpos($data['storage_string_id'], 'home::') === 0 \|\| strpos($data['storage_string_id'], 'object::user') === 0)) {`
`835`	`835`	`return false;`
`836`	`836`	`}`
`837`	`837`	`return true;`