Merge pull request #2680 from nextcloud/bugfix/noid/activity-empty-diff

Do not try to add change data if it doesn't exist

Author: juliusknorr

lib/Activity/DeckProvider.php

@@ -25,7 +25,6 @@
 
 namespace OCA\Deck\Activity;
 
-use cogpowered\FineDiff\Diff;
 use OCA\Deck\Db\Acl;
 use OCP\Activity\IEvent;
 use OCP\Activity\IProvider;
@@ -326,11 +325,9 @@ private function parseParamForDuedate($subjectParams, $params, IEvent $event) {
 	 * @return mixed
 	 */
 	private function parseParamForChanges($subjectParams, $params, $event) {
-		if (array_key_exists('diff', $subjectParams) && $subjectParams['diff']) {
-			$diff = new Diff();
+		if (array_key_exists('diff', $subjectParams) && $subjectParams['diff'] && !empty($subjectParams['after'])) {
 			// Don't add diff as message since we are limited to 255 chars here
 			$event->setParsedMessage($subjectParams['after']);
-			//$event->setParsedMessage('<pre class="visualdiff">' . $diff->render($subjectParams['before'], $subjectParams['after']) . '</pre>');
 			return $params;
 		}
 		if (array_key_exists('before', $subjectParams)) {