Merge pull request #57902 from nextcloud/useStrictOperator

susnux · web-flow · commit a6f4ed2cf8e8 · 2026-04-30T01:28:05.000+02:00
refactor: use strict operator
diff --git a/lib/base.php b/lib/base.php
@@ -120,8 +120,8 @@ public static function initPaths(): void {
 		if (substr($scriptName, -1) == '/') {
 			$scriptName .= 'index.php';
 			//make sure suburi follows the same rules as scriptName
-			if (substr(OC::$SUBURI, -9) != 'index.php') {
-				if (substr(OC::$SUBURI, -1) != '/') {
+			if (substr(OC::$SUBURI, -9) !== 'index.php') {
+				if (substr(OC::$SUBURI, -1) !== '/') {
 					OC::$SUBURI = OC::$SUBURI . '/';
 				}
 				OC::$SUBURI = OC::$SUBURI . 'index.php';
@@ -134,7 +134,7 @@ public static function initPaths(): void {
 			if (substr($scriptName, 0 - strlen(OC::$SUBURI)) === OC::$SUBURI) {
 				OC::$WEBROOT = substr($scriptName, 0, 0 - strlen(OC::$SUBURI));
 
-				if (OC::$WEBROOT != '' && OC::$WEBROOT[0] !== '/') {
+				if (OC::$WEBROOT !== '' && OC::$WEBROOT[0] !== '/') {
 					OC::$WEBROOT = '/' . OC::$WEBROOT;
 				}
 			} else {
@@ -239,7 +239,7 @@ public static function checkInstalled(\OC\SystemConfig $systemConfig): void {
 
 	public static function checkMaintenanceMode(\OC\SystemConfig $systemConfig): void {
 		// Allow ajax update script to execute without being stopped
-		if (((bool)$systemConfig->getValue('maintenance', false)) && OC::$SUBURI != '/core/ajax/update.php') {
+		if (((bool)$systemConfig->getValue('maintenance', false)) && OC::$SUBURI !== '/core/ajax/update.php') {
 			// send http status 503
 			http_response_code(503);
 			header('X-Nextcloud-Maintenance-Mode: 1');
diff --git a/lib/private/App/AppManager.php b/lib/private/App/AppManager.php
@@ -203,7 +203,7 @@ public function getAllAppsInAppsFolders(): array {
 			if (is_resource($dh)) {
 				while (($file = readdir($dh)) !== false) {
 					if (
-						$file[0] != '.'
+						$file[0] !== '.'
 						&& is_dir($apps_dir['path'] . '/' . $file)
 						&& is_file($apps_dir['path'] . '/' . $file . '/appinfo/info.xml')
 					) {
@@ -734,7 +734,7 @@ public function getAppPath(string $appId, bool $ignoreCache = false): string {
 			return __DIR__ . '/../../../core';
 		}
 
-		if (($dir = $this->findAppInDirectories($appId, $ignoreCache)) != false) {
+		if (($dir = $this->findAppInDirectories($appId, $ignoreCache)) !== false) {
 			return $dir['path'] . '/' . $appId;
 		}
 		throw new AppPathNotFoundException('Could not find path for ' . $appId);
@@ -747,7 +747,7 @@ public function getAppPath(string $appId, bool $ignoreCache = false): string {
 	 */
 	#[\Override]
 	public function getAppWebPath(string $appId): string {
-		if (($dir = $this->findAppInDirectories($appId)) != false) {
+		if (($dir = $this->findAppInDirectories($appId)) !== false) {
 			return \OC::$WEBROOT . $dir['url'] . '/' . $appId;
 		}
 		throw new AppPathNotFoundException('Could not find web path for ' . $appId);
diff --git a/lib/private/Contacts/ContactsMenu/ContactsStore.php b/lib/private/Contacts/ContactsMenu/ContactsStore.php
@@ -184,7 +184,7 @@ private function filterContacts(
 			$decodedExcludeGroups = json_decode($excludedGroups, true);
 			$excludeGroupsList = $decodedExcludeGroups ?? [];
 
-			if ($excludeGroups != 'allow') {
+			if ($excludeGroups !== 'allow') {
 				if (count($selfGroups) > 0 && count(array_diff($selfGroups, $excludeGroupsList)) === 0) {
 					// all the groups of the current user are excluded -> filter all local users
 					$skipLocal = true;
diff --git a/lib/private/Files/Cache/Cache.php b/lib/private/Files/Cache/Cache.php
@@ -551,7 +551,7 @@ private function getParentPath($path) {
 	 */
 	#[\Override]
 	public function inCache($file) {
-		return $this->getId($file) != -1;
+		return $this->getId($file) !== -1;
 	}
 
 	/**
diff --git a/lib/private/Files/Cache/Updater.php b/lib/private/Files/Cache/Updater.php
@@ -225,7 +225,7 @@ private function updateStorageMTimeOnly(string $internalPath): void {
 	private function correctParentStorageMtime(string $internalPath): void {
 		$parentId = $this->cache->getParentId($internalPath);
 		$parent = dirname($internalPath);
-		if ($parentId != -1) {
+		if ($parentId !== -1) {
 			$mtime = $this->storage->filemtime($parent);
 			if ($mtime !== false) {
 				try {
diff --git a/lib/private/Files/Mount/MountPoint.php b/lib/private/Files/Mount/MountPoint.php
@@ -225,7 +225,7 @@ private function formatPath($path) {
 	public function wrapStorage($wrapper) {
 		$storage = $this->getStorage();
 		// storage can be null if it couldn't be initialized
-		if ($storage != null) {
+		if ($storage !== null) {
 			$this->storage = $wrapper($this->mountPoint, $storage, $this);
 		}
 	}
diff --git a/lib/private/Files/ObjectStore/S3ObjectTrait.php b/lib/private/Files/ObjectStore/S3ObjectTrait.php
@@ -164,7 +164,7 @@ protected function writeMultiPart(string $urn, StreamInterface $stream, array $m
 					$totalWritten += $command['ContentLength'];
 				},
 				'before_complete' => function ($_command) use (&$totalWritten, $size, &$uploader, &$attempts): void {
-					if ($size !== null && $totalWritten != $size) {
+					if ($size !== null && $totalWritten !== $size) {
 						$e = new \Exception('Incomplete multi part upload, expected ' . $size . ' bytes, wrote ' . $totalWritten);
 						throw new MultipartUploadException($uploader->getState(), $e);
 					}
diff --git a/lib/private/Installer.php b/lib/private/Installer.php
@@ -632,7 +632,7 @@ private function copyRecursive(string $src, string $dest): void {
 			}
 			$files = scandir($src);
 			foreach ($files as $file) {
-				if ($file != '.' && $file != '..') {
+				if ($file !== '.' && $file !== '..') {
 					$this->copyRecursive("$src/$file", "$dest/$file");
 				}
 			}
diff --git a/lib/private/Log/File.php b/lib/private/Log/File.php
@@ -49,7 +49,7 @@ public function __construct(
 	public function write(string $app, $message, int $level): void {
 		$entry = $this->logDetailsAsJSON($app, $message, $level);
 		$handle = @fopen($this->logFile, 'a');
-		if ($this->logFileMode > 0 && is_file($this->logFile) && (fileperms($this->logFile) & 0777) != $this->logFileMode) {
+		if ($this->logFileMode > 0 && is_file($this->logFile) && (fileperms($this->logFile) & 0777) !== $this->logFileMode) {
 			@chmod($this->logFile, $this->logFileMode);
 		}
 		if ($handle) {
@@ -86,7 +86,7 @@ public function getEntries(int $limit = 50, int $offset = 0): array {
 				fseek($handle, $pos);
 				$ch = fgetc($handle);
 				if ($ch == "\n" || $pos == 0) {
-					if ($line != '') {
+					if ($line !== '') {
 						// Add the first character if at the start of the file,
 						// because it doesn't hit the else in the loop
 						if ($pos == 0) {
diff --git a/lib/private/Security/CertificateManager.php b/lib/private/Security/CertificateManager.php
@@ -50,7 +50,7 @@ public function listCertificates(): array {
 			return [];
 		}
 		while (false !== ($file = readdir($handle))) {
-			if ($file != '.' && $file != '..') {
+			if ($file !== '.' && $file !== '..') {
 				try {
 					$content = $this->view->file_get_contents($path . $file);
 					if ($content !== false) {
diff --git a/lib/private/Share20/Manager.php b/lib/private/Share20/Manager.php
@@ -791,15 +791,15 @@ public function updateShare(IShare $share, bool $onlyValid = true): IShare {
 		if ($share->getShareType() === IShare::TYPE_USER) {
 			$this->userCreateChecks($share);
 
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+			if ($share->getExpirationDate() !== $originalShare->getExpirationDate()) {
 				// Verify the expiration date
 				$this->validateExpirationDateInternal($share);
 				$expirationDateUpdated = true;
 			}
 		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
 			$this->groupCreateChecks($share);
 
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+			if ($share->getExpirationDate() !== $originalShare->getExpirationDate()) {
 				// Verify the expiration date
 				$this->validateExpirationDateInternal($share);
 				$expirationDateUpdated = true;
@@ -835,13 +835,13 @@ public function updateShare(IShare $share, bool $onlyValid = true): IShare {
 				}
 			}
 
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+			if ($share->getExpirationDate() !== $originalShare->getExpirationDate()) {
 				// Verify the expiration date
 				$this->validateExpirationDateLink($share);
 				$expirationDateUpdated = true;
 			}
 		} elseif ($share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+			if ($share->getExpirationDate() !== $originalShare->getExpirationDate()) {
 				// Verify the expiration date
 				$this->validateExpirationDateInternal($share);
 				$expirationDateUpdated = true;
diff --git a/lib/private/TemplateLayout.php b/lib/private/TemplateLayout.php
@@ -225,7 +225,7 @@ public function getPageTemplate(string $renderAs, string $appId): ITemplate {
 		// Add the js files
 		$jsFiles = $this->findJavascriptFiles(Util::getScripts());
 		$page->assign('jsfiles', []);
-		if ($this->config->getSystemValueBool('installed', false) && $renderAs != TemplateResponse::RENDER_AS_ERROR) {
+		if ($this->config->getSystemValueBool('installed', false) && $renderAs !== TemplateResponse::RENDER_AS_ERROR) {
 			// this is on purpose outside of the if statement below so that the initial state is prefilled (done in the getConfig() call)
 			// see https://github.com/nextcloud/server/pull/22636 for details
 			$jsConfigHelper = new JSConfigHelper(
diff --git a/lib/private/legacy/OC_Helper.php b/lib/private/legacy/OC_Helper.php
@@ -62,7 +62,7 @@ public static function copyr($src, $dest) {
 			}
 			$files = scandir($src);
 			foreach ($files as $file) {
-				if ($file != '.' && $file != '..') {
+				if ($file !== '.' && $file !== '..') {
 					self::copyr("$src/$file", "$dest/$file");
 				}
 			}
@@ -96,7 +96,7 @@ public static function canExecute($name, $path = false) {
 		$dirs = explode(PATH_SEPARATOR, (string)$path);
 		// WARNING : We have to check if open_basedir is enabled :
 		$obd = Server::get(IniGetWrapper::class)->getString('open_basedir');
-		if ($obd != 'none') {
+		if ($obd !== 'none') {
 			$obd_values = explode(PATH_SEPARATOR, $obd);
 			if (count($obd_values) > 0 && $obd_values[0]) {
 				// open_basedir is in effect !
diff --git a/lib/public/Util.php b/lib/public/Util.php
@@ -254,7 +254,7 @@ public static function linkToRemote($service) {
 		$urlGenerator = \OCP\Server::get(IURLGenerator::class);
 		$remoteBase = $urlGenerator->linkTo('', 'remote.php') . '/' . $service;
 		return $urlGenerator->getAbsoluteURL(
-			$remoteBase . (($service[strlen($service) - 1] != '/') ? '/' : '')
+			$remoteBase . (($service[strlen($service) - 1] !== '/') ? '/' : '')
 		);
 	}
 
@@ -267,7 +267,7 @@ public static function getServerHostName() {
 		$host_name = \OCP\Server::get(IRequest::class)->getServerHost();
 		// strip away port number (if existing)
 		$colon_pos = strpos($host_name, ':');
-		if ($colon_pos != false) {
+		if ($colon_pos !== false) {
 			$host_name = substr($host_name, 0, $colon_pos);
 		}
 		return $host_name;
@@ -471,7 +471,7 @@ public static function encodePath($component) {
 	 * @since 4.5.0
 	 */
 	public static function mb_array_change_key_case($input, $case = MB_CASE_LOWER, $encoding = 'UTF-8') {
-		$case = ($case != MB_CASE_UPPER) ? MB_CASE_LOWER : MB_CASE_UPPER;
+		$case = ($case !== MB_CASE_UPPER) ? MB_CASE_LOWER : MB_CASE_UPPER;
 		$ret = [];
 		foreach ($input as $k => $v) {
 			$ret[mb_convert_case($k, $case, $encoding)] = $v;

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ private function getParentPath($path) {`
`551`	`551`	`*/`
`552`	`552`	`#[\Override]`
`553`	`553`	`public function inCache($file) {`
`554`		`- return $this->getId($file) != -1;`
	`554`	`+ return $this->getId($file) !== -1;`
`555`	`555`	`}`
`556`	`556`
`557`	`557`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ private function formatPath($path) {`
`225`	`225`	`public function wrapStorage($wrapper) {`
`226`	`226`	`$storage = $this->getStorage();`
`227`	`227`	`// storage can be null if it couldn't be initialized`
`228`		`- if ($storage != null) {`
	`228`	`+ if ($storage !== null) {`
`229`	`229`	`$this->storage = $wrapper($this->mountPoint, $storage, $this);`
`230`	`230`	`}`
`231`	`231`	`}`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ protected function writeMultiPart(string $urn, StreamInterface $stream, array $m`
`164`	`164`	`$totalWritten += $command['ContentLength'];`
`165`	`165`	`},`
`166`	`166`	`'before_complete' => function ($_command) use (&$totalWritten, $size, &$uploader, &$attempts): void {`
`167`		`- if ($size !== null && $totalWritten != $size) {`
	`167`	`+ if ($size !== null && $totalWritten !== $size) {`
`168`	`168`	`$e = new \Exception('Incomplete multi part upload, expected ' . $size . ' bytes, wrote ' . $totalWritten);`
`169`	`169`	`throw new MultipartUploadException($uploader->getState(), $e);`
`170`	`170`	`}`
Original file line number	Diff line number	Diff line change
`@@ -632,7 +632,7 @@ private function copyRecursive(string $src, string $dest): void {`
`632`	`632`	`}`
`633`	`633`	`$files = scandir($src);`
`634`	`634`	`foreach ($files as $file) {`
`635`		`- if ($file != '.' && $file != '..') {`
	`635`	`+ if ($file !== '.' && $file !== '..') {`
`636`	`636`	`$this->copyRecursive("$src/$file", "$dest/$file");`
`637`	`637`	`}`
`638`	`638`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function listCertificates(): array {`
`50`	`50`	`return [];`
`51`	`51`	`}`
`52`	`52`	`while (false !== ($file = readdir($handle))) {`
`53`		`- if ($file != '.' && $file != '..') {`
	`53`	`+ if ($file !== '.' && $file !== '..') {`
`54`	`54`	`try {`
`55`	`55`	`$content = $this->view->file_get_contents($path . $file);`
`56`	`56`	`if ($content !== false) {`