Merge pull request #59902 from nextcloud/preload-storage-chukn

fix: chunk storage ids when preload storage info

Author: Altahrim

apps/dav/lib/Migration/Version1039Date20260408000000.php

@@ -22,6 +22,7 @@
 #[AddColumn(table: 'calendars', name: 'default_alarm_pday', type: ColumnType::INTEGER)]
 #[AddColumn(table: 'calendars', name: 'default_alarm_fday', type: ColumnType::INTEGER)]
 class Version1039Date20260408000000 extends SimpleMigrationStep {
+	#[\Override]
 	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
 		/** @var ISchemaWrapper $schema */
 		$schema = $schemaClosure();

lib/private/Files/Cache/StorageGlobal.php

@@ -42,21 +42,23 @@ public function loadForStorageIds(array $storageIds): void {
 		$builder = $this->connection->getQueryBuilder();
 		$query = $builder->select(['id', 'numeric_id', 'available', 'last_checked'])
 			->from('storages')
-			->where($builder->expr()->in('id', $builder->createNamedParameter(array_values($storageIds), IQueryBuilder::PARAM_STR_ARRAY)));
-
-		$result = $query->executeQuery();
-		while (($row = $result->fetch()) !== false) {
-			$normalizedRow = [
-				'id' => (string)$row['id'],
-				'numeric_id' => (int)$row['numeric_id'],
-				'available' => (bool)$row['available'],
-				'last_checked' => (int)$row['last_checked'],
-			];
-
-			$this->cache[$normalizedRow['id']] = $normalizedRow;
-		}
+			->where($builder->expr()->in('id', $builder->createParameter('ids'), IQueryBuilder::PARAM_STR_ARRAY));
+
+		foreach (array_chunk($storageIds, 1000) as $chunk) {
+			$query->setParameter('ids', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
 
-		$result->closeCursor();
+			$result = $query->executeQuery();
+			while (($row = $result->fetch()) !== false) {
+				$normalizedRow = [
+					'id' => (string)$row['id'],
+					'numeric_id' => (int)$row['numeric_id'],
+					'available' => (bool)$row['available'],
+					'last_checked' => (int)$row['last_checked'],
+				];
+
+				$this->cache[$normalizedRow['id']] = $normalizedRow;
+			}
+		}
 	}
 
 	/**