Skip to content

Commit d683cb9

Browse files
committed
tests: remove fragile pre-release tests
as we do not keep them anymore on the download server Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
1 parent 4c9cad0 commit d683cb9

7 files changed

Lines changed: 41 additions & 52 deletions

File tree

.github/workflows/test-stable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
strategy:
2424
matrix:
2525
php-versions: ["8.2", "8.3"]
26-
nextcloud-versions: ["26", "27", "28"]
26+
nextcloud-versions: ["26", "27", "31"]
2727
exclude:
2828
- php-versions: "8.3"
2929
nextcloud-versions: "26"

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ test-stable26: updater.phar test/vendor
3333
test-stable27: updater.phar test/vendor
3434
cd tests && ../vendor/bin/behat features/stable27.feature
3535

36-
test-stable28: updater.phar test/vendor
37-
cd tests && ../vendor/bin/behat features/stable28.feature
36+
test-stable31: updater.phar test/vendor
37+
cd tests && ../vendor/bin/behat features/stable31.feature
3838

3939
test-master: updater.phar test/vendor
4040
cd tests && ../vendor/bin/behat features/master.feature

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ The Updater can be accessed via the Web UI as well as the command line. It may b
1515

1616
## Known issues
1717

18-
* The `createBackup` step, which is **not** intended to backup user data, currently can slow down the larger the `datadirectory` gets (nextcloud/updater#507)
18+
* The `createBackup` step, which is **not** intended to backup user data, currently can slow down the larger the `datadirectory` gets (nextcloud/updater#507)
1919
* The `deleteOldFiles` step, which does not actually touch user data, currently can slow down the larger the `datadirectory` gets (nextcloud/updater#397)
2020
* Multiple `*.config.php` files are currently not supported / ignored (nextcloud/updater#384)
2121
* In some environments, the current iterator implementation may fail (nextcloud/updater#519)
@@ -236,7 +236,7 @@ check in the resulting `/updater.phar`.
236236

237237
#### Server components
238238

239-
Keep in mind that for the update/upgrade process there are some additional components that aren't part of the Updater app (nor necessarily part of
239+
Keep in mind that for the update/upgrade process there are some additional components that aren't part of the Updater app (nor necessarily part of
240240
`occ upgrade` itself):
241241

242242
* The Web-based update overview/notification page:
@@ -281,7 +281,7 @@ The available test targets are:
281281
| `make test-cli` | Runs only the CLI updater tests (`features/cli.feature`) |
282282
| `make test-stable26` | Tests update path for stable26 |
283283
| `make test-stable27` | Tests update path for stable27 |
284-
| `make test-stable28` | Tests update path for stable28 |
284+
| `make test-stable31` | Tests update path for stable31 |
285285
| `make test-master` | Tests update path for master |
286286
| `make test-user.ini` | Tests `.user.ini` handling (`features/user.ini.feature`) |
287287
| `make check-same-code-base` | Verifies `/index.php` is in sync with `/lib/*.php` + `/index.web.php` |
@@ -352,14 +352,14 @@ usually means:
352352
### Unable to use the built-in Updater
353353

354354
If the built-in Updater does not function reliably for your environment, the old reliable (albeit admittedly tedious) [manual update](https://docs.nextcloud.com/server/latest/admin_manual/maintenance/manual_upgrade.html) process may be your best alternative.
355-
This was the primary way of keeping Nextcloud Server up-to-date before the automated Updater was developed. In addition, if Updater does not work in your environment, report the details of your situation to https://github.com/nextcloud/updater/issues so that
355+
This was the primary way of keeping Nextcloud Server up-to-date before the automated Updater was developed. In addition, if Updater does not work in your environment, report the details of your situation to https://github.com/nextcloud/updater/issues so that
356356
consideration can be given to adapting Updater to a wider variety of environments.
357357

358358
### Updater != `occ upgrade`
359359

360360
The `occ upgrade` command runs the database migrations which adapt your existing database to the updated version Nextcloud Server that is deployed by the Updater (or via a manual update).
361361

362-
Despite the confusing naming - which makes sense technically, but in hindsight may not have been the best to avoid confusion - the Updater *must* run (and completely successfully) before `occ upgrade` will have anything to do.
362+
Despite the confusing naming - which makes sense technically, but in hindsight may not have been the best to avoid confusion - the Updater *must* run (and completely successfully) before `occ upgrade` will have anything to do.
363363

364364
## Help & Contributing
365365

tests/features/bootstrap/FeatureContext.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -242,18 +242,18 @@ public function getSignatureForVersion(string $version): string {
242242
vJJ8XVSDOlNNKjcgvcUMrsDItXioSwBst6vTdR5IKLAFivlb7HYLUN48R9h57QM2
243243
v8X/N49mF+Wk3PQa19wBVsUFYkaQuG9FTjUVgvp8bgv3s9rhrOLJa5KUOpdcodgZ
244244
faeql723PcZEzPJ3dzisSw==',
245-
'28.0.0beta4' => 'tguTYQ9w6cpQITNbVphOYsHGTvYPDi8aznjUM8Xyxi0HTIuK3WPBTdgrn7jPTC5+
246-
JlwoyTQTRI2ut0SvEzVK5OrKTotPtNaNRSwpo0VAtuavEAWK6ZtH0g5oujHDyn/7
247-
7S149qpPkbir6Lf7qMSSje92CF1LFOQDEqXW9HibfRVzMvTk2iTz//cTVcnyTxgi
248-
QbK5O5wLmo7Gp8UNZsHL6CXTHo7p8zd8I2T86poJAttgwGIGJ0rQe1AYh/kJEOEz
249-
CAzl6Rd033pBht1t9Y9mFfnWd70a4v9stSdhCwVo08fqxOcoJrCZQ4wwEWN3ReYj
250-
/xB2sIdvkLkDyESNNzmhmg==',
251-
'28.0.14' => 'e3wnEZE0ooyNX8CpsSEgXafLoOU/U+zORUyeqKczWuuf2Srq4edl2SCaQgvdSLsG
252-
DZo8h9LLEsh544/NyS8VOY7aJVqR2JOC4bUyztfNTnlppRLVTCIXx053Eht9+neN
253-
pYlPy8hBK+KBLoN7q3WYcWL1QOIrUAzgxhjwshMrTxNrHi8Nq7g37iZUzhPU5HWw
254-
MUID9gsQnT+aFurooLVvWMM8Ad0RkU72i5Y7I80c+v/2MYE9rxUmNC54noVePvrj
255-
R8zf/PC+Yj1vxFZ0hYAtweLgBxfwU5cNBYfH7M1I9FLlb88p/XDWx6XaBz4Ql6LK
256-
lbpDxNE9UiM09JG1dU7Ebg==',
245+
'31.0.7' => 'G1fL3cfRZNJt9yidE5cw5q/H+QSgyBZlo7KcUC0oZv0KB38P13h81myb9Ynf6r+f
246+
dojgY+VJr7ioKzjohjG0BBzZNGl08mdECywI0DrVEwwYOg5x4BYvUIyGpAuQgijW
247+
SoNnqZDlStK5tE70PKPR6s5KbA+aKyFmuchQrQCbWnhyAfyiYEZBATt4Rkdk3neP
248+
t3sSM5Io+IwcD+aURjrCFd+j2JBvBKZi0dDwsQ81kUAF8CibVtQRRFJPSDeBZi2Q
249+
+VMklACmI5DrMYwR+JA9q4l8XztwGanC97OT0glU/esvMccJ6qgSb0sFziDsiK28
250+
h4+1uFMEVz5dK0TY59GYLg==',
251+
'31.0.14' => 'oM4xe+KQxwzwGXq0JwYbt6xRsgu4Ejf9vrdNrNPZB/dnEDq/EWFLBJXoiq4Hfq+x
252+
IrJz+Cok4RjPg/NdNl/A+fWC47aJh+gPZUw0BITf8GZ/BeAzdlyxUG9+VrIMYEAR
253+
r93DL16y1mCk7dkkMC/a8DT5/orqXnWIP38wgXzbU+DcyA9eCq28+aSz25MLYSHR
254+
edNnmki3ovqsa4K6/5D+RvcXXwn4/xnk5Dboi8akNSEnXfmTpTJs8D8HqAXBrukl
255+
PA45206JcfSACC5ePc0ZfUPrV3ToKFlijsBdIsuNgpzmOIwukB4MUO+RLyk4lPOG
256+
ZwCpfYewGDvrElT50aJYkA==',
257257
];
258258

259259
return $signatures[$version] ?? '';

tests/features/stable27.feature

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
# SPDX-License-Identifier: AGPL-3.0-or-later
33
Feature: CLI updater - stable27 base
44

5-
Scenario: Update is available - 27.0.0 beta1 to 27.0.1 RC1
6-
Given the current installed version is 27.0.0beta1
7-
And there is an update to prerelease version "27.0.1rc1" available
8-
And the version number is decreased in the config.php to enforce upgrade
9-
When the CLI updater is run successfully
10-
And the output should contain "Update successful"
11-
Then the installed version should be 27.0
12-
And maintenance mode should be off
13-
And upgrade is not required
14-
155
Scenario: Update is available but unexpected folder found - 27.1.6 to 27.1.11
166
Given the current installed version is 27.1.6
177
And there is an update to version 27.1.11 available

tests/features/stable28.feature

Lines changed: 0 additions & 22 deletions
This file was deleted.

tests/features/stable31.feature

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
2+
# SPDX-License-Identifier: AGPL-3.0-or-later
3+
Feature: CLI updater - stable31 base
4+
5+
Scenario: Update is available - 31.0.7 to 31.0.14
6+
Given the current installed version is 31.0.7
7+
And there is an update to version 31.0.14 available
8+
When the CLI updater is run successfully
9+
And the output should contain "Update successful"
10+
Then the installed version should be 31.0.14
11+
And maintenance mode should be off
12+
And upgrade is not required
13+
14+
Scenario: Update is available - 30.0.17 to 31.0.14
15+
Given the current installed version is 30.0.17
16+
And there is an update to version 31.0.14 available
17+
When the CLI updater is run successfully
18+
And the output should contain "Update successful"
19+
Then the installed version should be 31.0.14
20+
And maintenance mode should be off
21+
And upgrade is not required

0 commit comments

Comments
 (0)