Skip to content

Commit 6308e6e

Browse files
committed
alternatice to version pinning
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
1 parent f02ea8b commit 6308e6e

7 files changed

Lines changed: 24 additions & 55 deletions

File tree

modules/nextflow/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ dependencies {
7676

7777
testImplementation 'org.subethamail:subethasmtp:3.1.7'
7878
testImplementation (project(':nf-lineage'))
79-
testImplementation 'org.wiremock:wiremock:3.13.1'
79+
testImplementation 'org.wiremock:wiremock:3.13.2'
8080
// test configuration
8181
testFixturesApi ("org.apache.groovy:groovy-test:4.0.31") { exclude group: 'org.apache.groovy' }
8282
testFixturesApi ("org.objenesis:objenesis:3.4")

modules/nf-commons/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ dependencies {
4545
testFixturesImplementation(project(":nextflow"))
4646

4747
testImplementation "org.apache.groovy:groovy-json:4.0.31" // needed by wiremock
48-
testImplementation ('org.wiremock:wiremock:3.13.1') { exclude module: 'groovy-all' }
48+
testImplementation ('org.wiremock:wiremock:3.13.2') { exclude module: 'groovy-all' }
4949
}
5050

modules/nf-httpfs/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ dependencies {
3636

3737
/* testImplementation inherited from top gradle build file */
3838
testImplementation "org.apache.groovy:groovy-json:4.0.31" // needed by wiremock
39-
testImplementation ('org.wiremock:wiremock:3.13.1') { exclude module: 'groovy-all' }
39+
testImplementation ('org.wiremock:wiremock:3.13.2') { exclude module: 'groovy-all' }
4040

4141
testImplementation(testFixtures(project(":nextflow")))
4242
}

plugins/nf-amazon/build.gradle

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -48,40 +48,30 @@ sourceSets {
4848
configurations {
4949
// see https://docs.gradle.org/4.1/userguide/dependency_management.html#sub:exclude_transitive_dependencies
5050
runtimeClasspath.exclude group: 'org.slf4j', module: 'slf4j-api'
51+
testRuntimeClasspath.exclude group: 'io.micronaut', module: 'micronaut-core-bom'
5152
}
5253

5354
dependencies {
54-
// Force patched Netty across all configurations (incl. testRuntimeClasspath, where
55-
// a transitive fixture would otherwise escalate to 4.2.x).
56-
// Addresses GHSA-pwqr-wmgm-9rr8 (netty-codec-http HTTP Request Smuggling)
57-
// and GHSA-w9fj-cfpg-grvv (netty-codec-http2 CONTINUATION Frame Flood DoS).
58-
constraints {
59-
implementation('io.netty:netty-buffer') { version { strictly '4.1.132.Final' } }
60-
implementation('io.netty:netty-common') { version { strictly '4.1.132.Final' } }
61-
implementation('io.netty:netty-handler') { version { strictly '4.1.132.Final' } }
62-
implementation('io.netty:netty-codec-http') { version { strictly '4.1.132.Final' } }
63-
implementation('io.netty:netty-codec-http2') { version { strictly '4.1.132.Final' } }
64-
}
6555

6656
compileOnly project(':nextflow')
6757
compileOnly 'org.slf4j:slf4j-api:2.0.17'
6858
compileOnly 'org.pf4j:pf4j:3.14.1'
6959

7060
api ('javax.xml.bind:jaxb-api:2.4.0-b180830.0359')
71-
api ('software.amazon.awssdk:s3:2.33.2')
72-
api ('software.amazon.awssdk:ec2:2.33.2')
73-
api ('software.amazon.awssdk:batch:2.33.2')
74-
api ('software.amazon.awssdk:iam:2.33.2')
75-
api ('software.amazon.awssdk:ecs:2.33.2')
76-
api ('software.amazon.awssdk:cloudwatchlogs:2.33.2')
77-
api ('software.amazon.awssdk:codecommit:2.33.2')
78-
api ('software.amazon.awssdk:sts:2.33.2')
79-
api ('software.amazon.awssdk:ses:2.33.2')
80-
api ('software.amazon.awssdk:sso:2.33.2')
81-
api ('software.amazon.awssdk:ssooidc:2.33.2')
82-
api ('software.amazon.awssdk:s3-transfer-manager:2.33.2')
83-
api ('software.amazon.awssdk:apache-client:2.33.2')
84-
api ('software.amazon.awssdk:aws-crt-client:2.33.2')
61+
api ('software.amazon.awssdk:s3:2.42.41')
62+
api ('software.amazon.awssdk:ec2:2.42.41')
63+
api ('software.amazon.awssdk:batch:2.42.41')
64+
api ('software.amazon.awssdk:iam:2.42.41')
65+
api ('software.amazon.awssdk:ecs:2.42.41')
66+
api ('software.amazon.awssdk:cloudwatchlogs:2.42.41')
67+
api ('software.amazon.awssdk:codecommit:2.42.41')
68+
api ('software.amazon.awssdk:sts:2.42.41')
69+
api ('software.amazon.awssdk:ses:2.42.41')
70+
api ('software.amazon.awssdk:sso:2.42.41')
71+
api ('software.amazon.awssdk:ssooidc:2.42.41')
72+
api ('software.amazon.awssdk:s3-transfer-manager:2.42.41')
73+
api ('software.amazon.awssdk:apache-client:2.42.41')
74+
api ('software.amazon.awssdk:aws-crt-client:2.42.41')
8575

8676
testImplementation(testFixtures(project(":nextflow")))
8777
testImplementation project(':nextflow')

plugins/nf-amazon/src/main/nextflow/cloud/aws/nio/S3Client.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.io.InputStream;
2222
import java.io.InterruptedIOException;
2323
import java.nio.file.*;
24+
import java.nio.file.AccessDeniedException;
2425
import java.nio.file.attribute.BasicFileAttributes;
2526
import java.util.EnumSet;
2627
import java.util.Queue;

plugins/nf-azure/build.gradle

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,22 +47,10 @@ sourceSets {
4747
configurations {
4848
// see https://docs.gradle.org/4.1/userguide/dependency_management.html#sub:exclude_transitive_dependencies
4949
runtimeClasspath.exclude group: 'org.slf4j', module: 'slf4j-api'
50+
testRuntimeClasspath.exclude group: 'io.micronaut', module: 'micronaut-core-bom'
5051
}
5152

5253
dependencies {
53-
// Force patched Netty across all configurations (incl. testRuntimeClasspath, where
54-
// a transitive fixture would otherwise escalate to 4.2.x).
55-
// Addresses GHSA-pwqr-wmgm-9rr8 (netty-codec-http HTTP Request Smuggling)
56-
// and GHSA-w9fj-cfpg-grvv (netty-codec-http2 CONTINUATION Frame Flood DoS).
57-
// netty-buffer must be pinned alongside the rest -- leaving it at 4.2.x
58-
// (via Micronaut BOM) causes ABI mismatch in AbstractByteBufAllocator.
59-
constraints {
60-
implementation('io.netty:netty-buffer') { version { strictly '4.1.132.Final' } }
61-
implementation('io.netty:netty-common') { version { strictly '4.1.132.Final' } }
62-
implementation('io.netty:netty-handler') { version { strictly '4.1.132.Final' } }
63-
implementation('io.netty:netty-codec-http') { version { strictly '4.1.132.Final' } }
64-
implementation('io.netty:netty-codec-http2') { version { strictly '4.1.132.Final' } }
65-
}
6654

6755
compileOnly project(':nextflow')
6856
compileOnly 'org.slf4j:slf4j-api:2.0.17'

plugins/nf-codecommit/build.gradle

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,29 +43,19 @@ sourceSets {
4343
configurations {
4444
// see https://docs.gradle.org/4.1/userguide/dependency_management.html#sub:exclude_transitive_dependencies
4545
runtimeClasspath.exclude group: 'org.slf4j', module: 'slf4j-api'
46+
testRuntimeClasspath.exclude group: 'io.micronaut', module: 'micronaut-core-bom'
4647
}
4748

4849
dependencies {
49-
// Force patched Netty across all configurations (incl. testRuntimeClasspath, where
50-
// a transitive fixture would otherwise escalate to 4.2.x).
51-
// Addresses GHSA-pwqr-wmgm-9rr8 (netty-codec-http HTTP Request Smuggling)
52-
// and GHSA-w9fj-cfpg-grvv (netty-codec-http2 CONTINUATION Frame Flood DoS).
53-
constraints {
54-
implementation('io.netty:netty-buffer') { version { strictly '4.1.132.Final' } }
55-
implementation('io.netty:netty-common') { version { strictly '4.1.132.Final' } }
56-
implementation('io.netty:netty-handler') { version { strictly '4.1.132.Final' } }
57-
implementation('io.netty:netty-codec-http') { version { strictly '4.1.132.Final' } }
58-
implementation('io.netty:netty-codec-http2') { version { strictly '4.1.132.Final' } }
59-
}
6050

6151
compileOnly project(':nextflow')
6252
compileOnly 'org.slf4j:slf4j-api:2.0.17'
6353
compileOnly 'org.pf4j:pf4j:3.14.1'
6454

6555
api ('javax.xml.bind:jaxb-api:2.4.0-b180830.0359')
66-
api ('software.amazon.awssdk:codecommit:2.31.64')
67-
api ('software.amazon.awssdk:sso:2.31.64')
68-
api ('software.amazon.awssdk:ssooidc:2.31.64')
56+
api ('software.amazon.awssdk:codecommit:2.42.41')
57+
api ('software.amazon.awssdk:sso:2.42.41')
58+
api ('software.amazon.awssdk:ssooidc:2.42.41')
6959

7060
testImplementation(testFixtures(project(":nextflow")))
7161
testImplementation project(':nextflow')

0 commit comments

Comments
 (0)