Skip to content

Commit 7bb7f2c

Browse files
committed
Override hasCredentials method for those provider subclasses that rely on tokens for authentication instead of modifying the parent class method
1 parent 7c0bf37 commit 7bb7f2c

4 files changed

Lines changed: 16 additions & 2 deletions

File tree

modules/nextflow/src/main/groovy/nextflow/scm/BitbucketRepositoryProvider.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ final class BitbucketRepositoryProvider extends RepositoryProvider {
4848

4949
@Override
5050
boolean hasCredentials() {
51-
return config.token
51+
return getToken()
5252
? true
5353
: super.hasCredentials()
5454
}

modules/nextflow/src/main/groovy/nextflow/scm/GiteaRepositoryProvider.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,13 @@ final class GiteaRepositoryProvider extends RepositoryProvider {
5353
return null
5454
}
5555

56+
@Override
57+
boolean hasCredentials() {
58+
return getToken()
59+
? true
60+
: super.hasCredentials()
61+
}
62+
5663
@Override
5764
@CompileDynamic
5865
List<BranchInfo> getBranches() {

modules/nextflow/src/main/groovy/nextflow/scm/GitlabRepositoryProvider.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ class GitlabRepositoryProvider extends RepositoryProvider {
5050
return null
5151
}
5252

53+
@Override
54+
boolean hasCredentials() {
55+
return getToken()
56+
? true
57+
: super.hasCredentials()
58+
}
59+
5360
@Override
5461
String getName() { "GitLab" }
5562

modules/nextflow/src/main/groovy/nextflow/scm/RepositoryProvider.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ abstract class RepositoryProvider {
126126
}
127127

128128
boolean hasCredentials() {
129-
return (getUser() && getPassword()) || getToken()
129+
getUser() && getPassword()
130130
}
131131

132132
String getUser() { config?.user }

0 commit comments

Comments
 (0)