Skip to content

uondrs_ada config file : WIP#715

Closed
ShahNiraj wants to merge 6 commits intonf-core:masterfrom
ShahNiraj:master
Closed

uondrs_ada config file : WIP#715
ShahNiraj wants to merge 6 commits intonf-core:masterfrom
ShahNiraj:master

Conversation

@ShahNiraj
Copy link
Copy Markdown


name: New Config : uondrs_ada
about: A new cluster config. I wish to add a new nfcore config file "uondrs_ada"

ShahNiraj added 6 commits July 5, 2024 11:03
First config
Added Profile config names for nf-core/configs
First nf-core config.
Added 'uondrs_ada.md' in the pipeline specific documentation section of this page
Added "uondrs_ada" to the profiles section
Comment thread README.md
- [genomes](docs/pipeline/viralrecon/genomes.md)

- rnaseq
- [uondrs_ada](docs/pipeline/rnaseq/uondrs_ada.md)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path doesn't seem to exist?

Comment thread conf/uondrs_ada.config
process {

// resources for default process execution
withLabel:process_low {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of process labels isn't exhaustive I think. Do you need to define them? Normally we've been recommending setting max resources in params (https://nf-co.re/docs/usage/getting_started/configuration#max-resources).

Nextflow has changed for the better since but that haven't yet reached everywhere, so I still think that's a good idea.

@Joon-Klaps
Copy link
Copy Markdown
Contributor

Hi @ShahNiraj,
do you think you will be able to work on this during the upcoming hackathon or do you need help getting this PR over the finish line? 😊

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented May 6, 2025

@ShahNiraj I am closing this PR due to a lack of activity from your end as it's been almost a year.

Feel free to re-open if it is still needed!

@jfy133 jfy133 closed this May 6, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in 2025 spring cleaning - the rest May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants