Skip to content

reducing process time limit#877

Merged
jfy133 merged 5 commits intonf-core:masterfrom
trombitomi:master
Apr 8, 2025
Merged

reducing process time limit#877
jfy133 merged 5 commits intonf-core:masterfrom
trombitomi:master

Conversation

@trombitomi
Copy link
Copy Markdown


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@nvnieuwk
Copy link
Copy Markdown
Contributor

nvnieuwk commented Apr 7, 2025

Hi @trombitomi thanks for this! Have you tested this using a Nextflow run on the HPC? I wanna be 100% sure this does not break anything

Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config does not seem valid, please fix this first :)

@pontus
Copy link
Copy Markdown
Collaborator

pontus commented Apr 7, 2025

Ah, yes. Probably needs quoting to be strings (that will be converted automatically). Alternatively 71.h+59.m I guess?

@trombitomi
Copy link
Copy Markdown
Author

trombitomi commented Apr 8, 2025

yes, my bad!
71.h59.m
("." was missing)
I updated this edit

@pontus
Copy link
Copy Markdown
Collaborator

pontus commented Apr 8, 2025

That doesn't look valid, have you tested?

@nvnieuwk
Copy link
Copy Markdown
Contributor

nvnieuwk commented Apr 8, 2025

It should be "71hours 59minutes". See the docs on time duration notation

@trombitomi
Copy link
Copy Markdown
Author

Sorry, in interactive it seemed to work, now corrected. It works in batch submission.

@jfy133 jfy133 merged commit 3afd9ad into nf-core:master Apr 8, 2025
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants