Skip to content

Update eddie.config#891

Merged
ggrimes merged 2 commits intonf-core:masterfrom
ggrimes:patch-10
May 9, 2025
Merged

Update eddie.config#891
ggrimes merged 2 commits intonf-core:masterfrom
ggrimes:patch-10

Conversation

@ggrimes
Copy link
Copy Markdown
Contributor

@ggrimes ggrimes commented Apr 18, 2025

changed version of singularity that module loads in eddie.config


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

changed version of singularity that module loads in eddie.config
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented May 6, 2025

@ggrimes just as a reminder, in this repository merging should be performed by the PR author once you have approval (as other community members cannot be responsible for the running of pipelines using the config on your infrastructure).

@ggrimes ggrimes requested a review from pontus May 6, 2025 08:10
@ggrimes
Copy link
Copy Markdown
Contributor Author

ggrimes commented May 6, 2025

@ggrimes just as a reminder, in this repository merging should be performed by the PR author once you have approval (as other community members cannot be responsible for the running of pipelines using the config on your infrastructure).

I am a little confused as to how I finalise this PR now it has been approved.

@pontus
Copy link
Copy Markdown
Collaborator

pontus commented May 6, 2025

Do you have a "Merge pull request" button you can click?

@ggrimes
Copy link
Copy Markdown
Contributor Author

ggrimes commented May 6, 2025

Do you have a "Merge pull request" button you can click?

I can't see one.

@pontus
Copy link
Copy Markdown
Collaborator

pontus commented May 6, 2025

Hrrm, I suspect it's because you're not in the nf-core organisation, can you join? https://nf-co.re/join#github

@ggrimes ggrimes merged commit 41a2d90 into nf-core:master May 9, 2025
150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants