Skip to content

Commit 0644abd

Browse files
authored
Merge pull request #660 from jfy133/dev
Patch release with readgroup fixes and to get docker working
2 parents 7c0938d + 9d87d69 commit 0644abd

5 files changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ jobs:
3434
3535
- name: Build new docker image
3636
if: env.MATCHED_FILES
37-
run: docker build --no-cache . -t nfcore/eager:dev
37+
run: docker build --no-cache . -t nfcore/eager:2.3.1
3838

3939
- name: Pull docker image
4040
if: ${{ !env.MATCHED_FILES }}
4141
run: |
4242
docker pull nfcore/eager:dev
43-
docker tag nfcore/eager:dev nfcore/eager:dev
43+
docker tag nfcore/eager:dev nfcore/eager:2.3.1
4444
4545
- name: Install Nextflow
4646
env:

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
55

6-
## [2.3.1dev] - Unreleased
6+
## [2.3.1] - 2021-01-14
77

88
### `Added`
99

1010
### `Fixed`
1111

1212
- [#654](https://github.com/nf-core/eager/issues/654) - Fixed some values in JSON schema (used in launch GUI) not passing validation checks during run
1313
- [#655](https://github.com/nf-core/eager/issues/655) - Updated read groups for all mappers to allow proper GATK validation
14+
- Fixed issue with Docker container not being pullable by Nextflow due to version-number inconsistencies
1415

1516
### `Dependencies`
1617

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ COPY environment.yml /
77
RUN conda env create --quiet -f /environment.yml && conda clean -a
88

99
# Add conda installation dir to PATH (instead of doing 'conda activate')
10-
ENV PATH /opt/conda/envs/nf-core-eager-2.3.1dev/bin:$PATH
10+
ENV PATH /opt/conda/envs/nf-core-eager-2.3.1/bin:$PATH
1111

1212
# Dump the details of the installed packages to a file for posterity
13-
RUN conda env export --name nf-core-eager-2.3.1dev > nf-core-eager-2.3.1dev.yml
13+
RUN conda env export --name nf-core-eager-2.3.1 > nf-core-eager-2.3.1.yml
1414

1515
# Instruct R processes to use these empty files instead of clashing with a local version
1616
RUN touch .Rprofile

environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# You can use this file to create a conda environment for this pipeline:
22
# conda env create -f environment.yml
3-
name: nf-core-eager-2.3.1dev
3+
name: nf-core-eager-2.3.1
44
channels:
55
- conda-forge
66
- bioconda

nextflow.config

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ params {
251251

252252
// Container slug. Stable releases should specify release tag!
253253
// Developmental code should specify :dev
254-
process.container = 'nfcore/eager:dev'
254+
process.container = 'nfcore/eager:2.3.1'
255255

256256
// Load base.config by default for all pipelines
257257
includeConfig 'conf/base.config'
@@ -345,7 +345,7 @@ manifest {
345345
description = 'A fully reproducible and state-of-the-art ancient DNA analysis pipeline'
346346
mainScript = 'main.nf'
347347
nextflowVersion = '!>=20.04.0'
348-
version = '2.3.1dev'
348+
version = '2.3.1'
349349
}
350350

351351
// Function to ensure that resource requirements don't go beyond

0 commit comments

Comments
 (0)