Skip to content

Commit 398f9fb

Browse files
authored
Merge branch 'dev' into patch-testconfig_params_updates
2 parents d6cafa8 + 9086bad commit 398f9fb

2 files changed

Lines changed: 15 additions & 14 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1111

1212
- [#882](https://github.com/nf-core/eager/pull/882) Define DSL1 execution explicitly, as new versions Nextflow made DSL2 default (♥ to & fix from @Lehmann-Fabian)
1313
- [#879](https://github.com/nf-core/eager/issues/879) Add missing threads parameter for pre-clipping FastQC for single end data that caused insufficient memory in some cases (♥ to @marcel-keller for reporting)
14+
- [#885](https://github.com/nf-core/eager/issues/885) Specify task memory for all tools in get_software_versions to account for incompatibilty of java with some SGE clusters causing hanging of the process (♥ to @maxibor for reporting)
1415
- [#889](https://github.com/nf-core/eager/issues/889) Remove/updated parameters from benchmarking test profiles (♥ to @TCLamnidis for reporting)
1516

1617
### `Dependencies`

main.nf

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3113,39 +3113,39 @@ process get_software_versions {
31133113
echo $workflow.manifest.version &> v_pipeline.txt
31143114
echo $workflow.nextflow.version &> v_nextflow.txt
31153115
3116-
fastqc --version &> v_fastqc.txt 2>&1 || true
3116+
fastqc -t ${task.cpus} --version &> v_fastqc.txt 2>&1 || true
31173117
AdapterRemoval --version &> v_adapterremoval.txt 2>&1 || true
31183118
fastp --version &> v_fastp.txt 2>&1 || true
31193119
bwa &> v_bwa.txt 2>&1 || true
3120-
circulargenerator --help | head -n 1 &> v_circulargenerator.txt 2>&1 || true
3120+
circulargenerator -Xmx${task.memory.toGiga()}g --help | head -n 1 &> v_circulargenerator.txt 2>&1 || true
31213121
samtools --version &> v_samtools.txt 2>&1 || true
3122-
dedup -v &> v_dedup.txt 2>&1 || true
3122+
dedup -Xmx${task.memory.toGiga()}g -v &> v_dedup.txt 2>&1 || true
31233123
## bioconda recipe of picard is incorrectly set up and extra warning made with stderr, this ugly command ensures only version exported
3124-
( exec 7>&1; picard MarkDuplicates --version 2>&1 >&7 | grep -v '/' >&2 ) 2> v_markduplicates.txt || true
3125-
qualimap --version &> v_qualimap.txt 2>&1 || true
3124+
( exec 7>&1; picard -Xmx${task.memory.toMega()}M MarkDuplicates --version 2>&1 >&7 | grep -v '/' >&2 ) 2> v_markduplicates.txt || true
3125+
qualimap --version --java-mem-size=${task.memory.toGiga()}G &> v_qualimap.txt 2>&1 || true
31263126
preseq &> v_preseq.txt 2>&1 || true
3127-
gatk --version 2>&1 | grep '(GATK)' > v_gatk.txt 2>&1 || true
3128-
gatk3 --version 2>&1 | head -n 1 > v_gatk3.txt 2>&1 || true
3127+
gatk --java-options "-Xmx${task.memory.toGiga()}G" --version 2>&1 | grep '(GATK)' > v_gatk.txt 2>&1 || true
3128+
gatk3 -Xmx${task.memory.toGiga()}g --version 2>&1 | head -n 1 > v_gatk3.txt 2>&1 || true
31293129
freebayes --version &> v_freebayes.txt 2>&1 || true
31303130
bedtools --version &> v_bedtools.txt 2>&1 || true
3131-
damageprofiler --version &> v_damageprofiler.txt 2>&1 || true
3131+
damageprofiler -Xmx${task.memory.toGiga()}g --version &> v_damageprofiler.txt 2>&1 || true
31323132
bam --version &> v_bamutil.txt 2>&1 || true
31333133
pmdtools --version &> v_pmdtools.txt 2>&1 || true
31343134
angsd -h |& head -n 1 | cut -d ' ' -f3-4 &> v_angsd.txt 2>&1 || true
3135-
multivcfanalyzer --help | head -n 1 &> v_multivcfanalyzer.txt 2>&1 || true
3136-
malt-run --help |& tail -n 3 | head -n 1 | cut -f 2 -d'(' | cut -f 1 -d ',' &> v_malt.txt 2>&1 || true
3137-
MaltExtract --help | head -n 2 | tail -n 1 &> v_maltextract.txt 2>&1 || true
3135+
multivcfanalyzer -Xmx${task.memory.toGiga()}g --help | head -n 1 &> v_multivcfanalyzer.txt 2>&1 || true
3136+
malt-run -J-Xmx${task.memory.toGiga()}g --help |& tail -n 3 | head -n 1 | cut -f 2 -d'(' | cut -f 1 -d ',' &> v_malt.txt 2>&1 || true
3137+
MaltExtract -Xmx${task.memory.toGiga()}g --help | head -n 2 | tail -n 1 &> v_maltextract.txt 2>&1 || true
31383138
multiqc --version &> v_multiqc.txt 2>&1 || true
3139-
vcf2genome -h |& head -n 1 &> v_vcf2genome.txt || true
3140-
mtnucratio --help &> v_mtnucratiocalculator.txt || true
3139+
vcf2genome -Xmx${task.memory.toGiga()}g -h |& head -n 1 &> v_vcf2genome.txt || true
3140+
mtnucratio -Xmx${task.memory.toGiga()}g --help &> v_mtnucratiocalculator.txt || true
31413141
sexdeterrmine --version &> v_sexdeterrmine.txt || true
31423142
kraken2 --version | head -n 1 &> v_kraken.txt || true
31433143
endorS.py --version &> v_endorSpy.txt || true
31443144
pileupCaller --version &> v_sequencetools.txt 2>&1 || true
31453145
bowtie2 --version | grep -a 'bowtie2-.* -fdebug' > v_bowtie2.txt || true
31463146
eigenstrat_snp_coverage --version | cut -d ' ' -f2 >v_eigenstrat_snp_coverage.txt || true
31473147
mapDamage --version > v_mapdamage.txt || true
3148-
bbduk.sh | grep 'Last modified' | cut -d ' ' -f 3-99 > v_bbduk.txt || true
3148+
bbversion.sh > v_bbduk.txt || true
31493149
bcftools --version | grep 'bcftools' | cut -d ' ' -f 2 > v_bcftools.txt || true
31503150
scrape_software_versions.py &> software_versions_mqc.yaml
31513151
"""

0 commit comments

Comments
 (0)