Skip to content

Commit 416d0fe

Browse files
authored
Merge branch 'dev' into damageprofiler-more
2 parents 0b7f779 + 4d2f062 commit 416d0fe

28 files changed

Lines changed: 734 additions & 448 deletions

.github/CONTRIBUTING.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ We try to manage the required tasks for nf-core/eager using GitHub issues, you p
66

77
However, don't be put off by this template - other more general issues and suggestions are welcome! Contributions to the code are even more welcome ;)
88

9-
> If you need help using or modifying nf-core/eager then the best place to go is the Gitter chatroom where you can ask us questions directly: https://gitter.im/nf-core/Lobby
9+
> If you need help using or modifying nf-core/eager then the best place to ask is on the pipeline channel on [Slack](https://nf-core-invite.herokuapp.com/).
10+
11+
1012

1113
## Contribution workflow
1214
If you'd like to write some code for nf-core/eager, the standard workflow
@@ -30,7 +32,7 @@ Typically, pull-requests are only fully reviewed when these tests are passing, t
3032
There are typically two types of tests that run:
3133

3234
### Lint Tests
33-
The nf-core has a [set of guidelines](http://nf-co.re/developer_docs) which all pipelines must adhere to.
35+
The nf-core has a [set of guidelines](http://nf-co.re/guidelines) which all pipelines must adhere to.
3436
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core lint <pipeline-directory>` command.
3537

3638
If any failures or warnings are encountered, please follow the listed URL for more documentation.
@@ -42,4 +44,4 @@ If there are any failures then the automated tests fail.
4244
These tests are run both with the latest available version of Nextflow and also the minimum required version that is stated in the pipeline code.
4345

4446
## Getting help
45-
For further information/help, please consult the [nf-core/eager documentation](https://github.com/nf-core/eager#documentation) and don't hesitate to get in touch on [Gitter](https://gitter.im/nf-core/Lobby)
47+
For further information/help, please consult the [nf-core/eager documentation](https://github.com/nf-core/eager#documentation) and don't hesitate to get in touch on the pipeline channel on [Slack](https://nf-core-invite.herokuapp.com/).

.github/markdownlint.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Markdownlint configuration file
2+
default: true,
3+
line-length: false
4+
no-multiple-blanks: 0
5+
blanks-around-headers: false
6+
blanks-around-lists: false
7+
header-increment: false
8+
no-duplicate-header:
9+
siblings_only: true

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ data/
44
results/
55
.DS_Store
66
tests/test_data
7+
*.pyc

.travis.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ before_install:
1313
# Pull the docker image first so the test doesn't wait for this
1414
- docker pull nfcore/eager:dev
1515
# Fake the tag locally so that the pipeline runs properly
16+
# Looks weird when this is :dev to :dev, but makes sense when testing code for a release (:dev to :1.0.1)
1617
- docker tag nfcore/eager:dev nfcore/eager:dev
1718

1819
install:
@@ -21,13 +22,16 @@ install:
2122
- wget -qO- get.nextflow.io | bash
2223
- sudo ln -s /tmp/nextflow/nextflow /usr/local/bin/nextflow
2324
# Install nf-core/tools
25+
- pip install --upgrade pip
2426
- pip install nf-core
2527
# Install Conda
2628
- wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh
2729
- bash Miniconda3-latest-Linux-x86_64.sh -b -f -p $HOME/miniconda
2830
- export PATH="$HOME/miniconda/bin:$PATH"
2931
# Reset
3032
- mkdir ${TRAVIS_BUILD_DIR}/tests && cd ${TRAVIS_BUILD_DIR}/tests
33+
# Install markdownlint-cli
34+
- sudo apt-get install npm && npm install -g markdownlint-cli
3135

3236
env:
3337
- NXF_VER='0.32.0' # Specify a minimum NF version that should be tested and work
@@ -46,6 +50,8 @@ script:
4650
- nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pairedEnd --skip_trim --saveReference
4751
# Run the basic pipeline with paired end data without adapterRemoval
4852
- nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pairedEnd --skip_adapterremoval --saveReference
53+
# Run the basic pipeline with output unmapped reads as fastq
54+
- nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pairedEnd --strip_input_fastq
4955
# Run the same pipeline testing optional step: fastp, complexity
5056
- nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pairedEnd --complexity_filter --bwa_index results/reference_genome/bwa_index/bwa_index/
5157
# Test BAM Trimming

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,25 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
88

99
### `Added`
1010

11+
* [#189](https://github.com/nf-core/eager/pull/189) - Outputing unmapped reads in a fastq files with the --strip_input_fastq flag
12+
* [#186](https://github.com/nf-core/eager/pull/186) - Make FastQC skipping [possible]
13+
/(https://github.com/nf-core/eager/issues/182)
14+
* Merged in [nf-core/tools](https://github.com/nf-core/tools) release V1.6 template changes
15+
1116
### `Fixed`
1217
* [#152](https://github.com/nf-core/eager/pull/152) - DamageProfiler errors [won't crash entire pipeline anymore](https://github.com/nf-core/eager/issues/171)
1318
* [#176](https://github.com/nf-core/eager/pull/176) - Increase runtime for DamageProfiler on [large reference genomes](https://github.com/nf-core/eager/issues/173)
19+
* [#172](https://github.com/nf-core/eager/pull/152) - DamageProfiler errors [won't crash entire pipeline anymore](https://github.com/nf-core/eager/issues/171)
20+
* [#174](https://github.com/nf-core/eager/pull/190) - Publish DeDup files [properly](https://github.com/nf-core/eager/issues/183)
1421

1522
### `Dependencies`
1623

1724
* Added DeDup v0.12.5 (json support)
1825
* Added mtnucratio v0.5 (json support)
26+
* Updated Picard 2.18.27 -> 2.19.0
27+
* Updated GATK 4.1.0.0 -> 4.1.1.1
28+
* Updated damageprofiler 0.4.4 -> 0.4.5
29+
* Updated r-rmarkdown 1.11 -> 1.12
1930

2031

2132
## [2.0.6] - 2019-03-05

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ This Code of Conduct applies both within project spaces and in public spaces whe
3434

3535
## Enforcement
3636

37-
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team on the [Gitter channel](https://gitter.im/nf-core/Lobby). The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
37+
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team on [Slack](https://nf-core-invite.herokuapp.com/). The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
3838

3939
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
4040

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2018 Alexander Peltzer
3+
Copyright (c) Alexander Peltzer, Stephen Clayton, James A. Fellows Yates, Maxime Borry
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# ![nf-core/eager](docs/images/eager_logo.png)
22

3-
[![Build Status](https://travis-ci.org/nf-core/eager.svg?branch=master)](https://travis-ci.org/nf-core/eager)
3+
**A fully reproducible ancient and modern DNA pipeline in Nextflow and with cloud support.**.
4+
5+
[![Build Status](https://travis-ci.com/nf-core/eager.svg?branch=master)](https://travis-ci.com/nf-core/eager)
46
[![Nextflow](https://img.shields.io/badge/nextflow-%E2%89%A50.32.0-brightgreen.svg)](https://www.nextflow.io/)
57
[![Slack Status](https://nf-core-invite.herokuapp.com/badge.svg)](https://nf-core-invite.herokuapp.com)[![install with bioconda](https://img.shields.io/badge/install%20with-bioconda-brightgreen.svg)](http://bioconda.github.io/)
68
[![Docker Container available](https://img.shields.io/docker/automated/nfcore/eager.svg)](https://hub.docker.com/r/nfcore/eager/)
79
![Singularity Container available](https://img.shields.io/badge/singularity-available-7E4C74.svg)
810
[![DOI](https://zenodo.org/badge/135918251.svg)](https://zenodo.org/badge/latestdoi/135918251)
911

10-
11-
1212
## Introduction
1313

1414
**nf-core/eager** is a bioinformatics best-practice analysis pipeline for NGS
@@ -44,7 +44,7 @@ Additional functionality contained by the pipeline currently includes:
4444

4545
## Quick Start
4646

47-
1. Install [`nextflow`](docs/installation.md)
47+
1. Install [`nextflow`](https://nf-co.re/usage/installation)
4848

4949
2. Install one of [`docker`](https://docs.docker.com/engine/installation/), [`singularity`](https://www.sylabs.io/guides/3.0/user-guide/) or [`conda`](https://conda.io/miniconda.html)
5050

@@ -73,22 +73,24 @@ as described in the documentation.
7373

7474
## Documentation
7575

76-
The nf-core/eager pipeline comes with documentation about the pipeline, found in the `docs/` directory:
76+
The nf-core/eager pipeline comes with documentation about the pipeline, found in the `docs/` directory or on the main homepage of the nf-core project:
7777

78-
1. [Installation](docs/installation.md)
78+
1. [Nextflow Installation](https://nf-co.re/usage/installation)
7979
2. Pipeline configuration
80-
* [Local installation](docs/configuration/local.md)
81-
* [Adding your own system](docs/configuration/adding_your_own.md)
80+
* [Pipeline installation](https://nf-co.re/usage/local_installation)
81+
* [Adding your own system config](https://nf-co.re/usage/adding_own_config)
82+
* [Reference genomes](https://nf-co.re/usage/reference_genomes)
8283
3. [Running the pipeline](docs/usage.md)
8384
4. [Output and how to interpret the results](docs/output.md)
84-
5. [Troubleshooting](docs/troubleshooting.md)
85+
5. [Troubleshooting](https://nf-co.re/usage/troubleshooting)
86+
6. [EAGER Troubleshooting](docs/troubleshooting.md)
8587

8688

8789
## Credits
8890

8991
This pipeline was written by Alexander Peltzer ([apeltzer](https://github.com/apeltzer)),
9092
with major contributions from Stephen Clayton, ideas and documentation from
91-
James Fellows Yates, Raphael Eisenhofer and Judith Neukamm. If you want to
93+
James A. Fellows Yates, Raphael Eisenhofer, Maxime Borry and Judith Neukamm. If you want to
9294
contribute, please open an issue and ask to be added to the project - happy to
9395
do so and everyone is welcome to contribute here!
9496

Singularity

Lines changed: 0 additions & 18 deletions
This file was deleted.

assets/email_template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<meta http-equiv="X-UA-Compatible" content="IE=edge">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
77

8-
<meta name="description" content="nf-core/eager: {{ cookiecutter.description }}">
8+
<meta name="description" content="nf-core/eager: A fully reproducible ancient and modern DNA pipeline in Nextflow and with cloud support.">
99
<title>nf-core/eager Pipeline Report</title>
1010
</head>
1111
<body>

0 commit comments

Comments
 (0)