Skip to content

Commit 435812b

Browse files
authored
Merge pull request #145 from apeltzer/fix-picard
Fix picard memory issue
2 parents e039f28 + 949fd28 commit 435812b

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [Unpublished / Dev Branch]
88

9+
### `Added`
10+
11+
### `Fixed`
12+
* [#145](https://github.com/nf-core/eager/issues/145) - Added Picard Memory Handling [fix](https://github.com/nf-core/eager/issues/144)
13+
14+
915
## [2.0.5] - 2019-01-28
1016

1117
### `Added`

conf/base.config

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ process {
3131
withName:convertBam {
3232
cpus = { check_max(8 * task.attempt, 'cpus') }
3333
}
34-
34+
withName:makeSeqDict {
35+
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
36+
}
37+
3538
withName:bwa {
3639
memory = { check_max( 16.GB * task.attempt, 'memory' ) }
3740
cpus = { check_max(8 * task.attempt, 'cpus') }

main.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ process makeSeqDict {
488488
mkdir -p seq_dict
489489
mv $fasta "seq_dict/${base}"
490490
cd seq_dict
491-
picard CreateSequenceDictionary R=$base O="${fasta.baseName}.dict"
491+
picard -Xmx${task.memory.toMega()}M -Xms${task.memory.toMega()}M CreateSequenceDictionary R=$base O="${fasta.baseName}.dict"
492492
"""
493493
}
494494

@@ -970,7 +970,7 @@ process markDup{
970970
script:
971971
prefix = "${bam.baseName}"
972972
"""
973-
picard MarkDuplicates INPUT=$bam OUTPUT=${prefix}.markDup.bam REMOVE_DUPLICATES=TRUE AS=TRUE METRICS_FILE="${prefix}.markdup.metrics" VALIDATION_STRINGENCY=SILENT
973+
picard -Xmx${task.memory.toMega()}M -Xms${task.memory.toMega()}M MarkDuplicates INPUT=$bam OUTPUT=${prefix}.markDup.bam REMOVE_DUPLICATES=TRUE AS=TRUE METRICS_FILE="${prefix}.markdup.metrics" VALIDATION_STRINGENCY=SILENT
974974
"""
975975
}
976976

0 commit comments

Comments
 (0)