Skip to content

Commit 43958a0

Browse files
committed
Merge branch 'dev' of github.com:nf-core/eager into dev
2 parents 8f916b6 + 5a4621b commit 43958a0

15 files changed

Lines changed: 1177 additions & 730 deletions

CHANGELOG.md

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,32 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
88
### `Added`
99

1010
- [#687](https://github.com/nf-core/eager/pull/687) - Adds Kraken2 unique kmer counting report
11+
- [#676](https://github.com/nf-core/eager/issues/676) - Refactor help message / summary message formatting to automatic versions using nf-core library
12+
- [#682](https://github.com/nf-core/eager/issues/682) - Add AdapterRemoval `--qualitymax` flag to allow FASTQ Phred score range max more than 41
1113

1214
### `Fixed`
1315

1416
- [#666](https://github.com/nf-core/eager/issues/666) - Fixed input file staging for `print_nuclear_contamination`
1517
- [#631](https://github.com/nf-core/eager/issues/631) - Update minimum Nextflow version to 20.07.1, due to unfortunate bug in Nextflow 20.04.1 causing eager to crash if patch pulled
1618
- Made MultiQC crash behaviour stricter when dealing with large datasets, as reported by @ashildv
17-
- [#652](https://github.com/nf-core/eager/issues/652) Added note to documentation that when using `--skip_collapse` this will use _paired-end_ alignment mode with mappers when using PE data
19+
- [#652](https://github.com/nf-core/eager/issues/652) - Added note to documentation that when using `--skip_collapse` this will use _paired-end_ alignment mode with mappers when using PE data
1820
- [#626](https://github.com/nf-core/eager/issues/626) - Add additional checks to ensure pipeline will give useful error if cells of a TSV column are empty
19-
- Added note to documentation that when using `--skip_collapse` this will use _paired-end_ alignment mode with mappers when using PE data. `
20-
- [#673](https://github.com/nf-core/eager/pull/673) Fix Kraken database loading when loading from directory instead of compressed file.
21+
- Added note to documentation that when using `--skip_collapse` this will use _paired-end_ alignment mode with mappers when using PE data
22+
- [#673](https://github.com/nf-core/eager/pull/673) - Fix Kraken database loading when loading from directory instead of compressed file
2123
- [#688](https://github.com/nf-core/eager/issues/668) - Allow pipeline to complete, even if Qualimap crashes due to an empty or corrupt BAM file for one sample/library
22-
- [#683](https://github.com/nf-core/eager/pull/683) - Sets `--igenomes_ignore` to true by default, as rarely used by users currently and makes resolving configs less complex.
24+
- [#683](https://github.com/nf-core/eager/pull/683) - Sets `--igenomes_ignore` to true by default, as rarely used by users currently and makes resolving configs less complex
25+
- Added exit code `140` to re-tryable exit code list to account for certain scheduler wall-time limit fails
26+
- [672](https://github.com/nf-core/eager/issues/672) - Removed java parameter from picard tools which could cause memory issues
27+
- [679](https://github.com/nf-core/eager/issues/679) - Refactor within-process bash conditions to groovy/nextflow, due to incompatibility with some servers environments
28+
- [#690](https://github.com/nf-core/eager/pull/690) - Fixed ANGSD output mode for beagle by setting `-doMajorMinor 1` as default in that case
29+
- [#693](https://github.com/nf-core/eager/issues/693) - Fixed broken TSV input validation for the Colour Chemistry column
30+
- [#695](https://github.com/nf-core/eager/issues/695) - Fixed incorrect `-profile` order in tutorials (originally written reversed due to [nextflow bug](https://github.com/nextflow-io/nextflow/issues/1792))
2331

2432
### `Dependencies`
2533

34+
- Bumped MultiQC to 1.10 for improved functionality
35+
- Bumped HOPS to 0.35 for MultiQC 1.10 compatibility
36+
2637
### `Deprecated`
2738

2839
## [2.3.1] - 2021-01-14

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ of this pipeline:
158158

159159
Those who have provided conceptual guidance, suggestions, bug reports etc.
160160

161+
* [Alexandre Gilardet](https://github.com/alexandregilardet)
161162
* Arielle Munters
162163
* [Charles Plessy](https://github.com/charles-plessy)
163164
* [Åshild Vågene](https://github.com/ashildv)

conf/base.config

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ process {
1414
memory = { check_max( 7.GB * task.attempt, 'memory' ) }
1515
time = { check_max( 24.h * task.attempt, 'time' ) }
1616

17-
errorStrategy = { task.exitStatus in [143,137,104,134,139] ? 'retry' : 'finish' }
17+
errorStrategy = { task.exitStatus in [143,137,104,134,139, 140] ? 'retry' : 'finish' }
1818
maxRetries = 3
1919
maxErrors = '-1'
2020

@@ -74,34 +74,34 @@ process {
7474
}
7575

7676
withName:qualimap{
77-
errorStrategy = { task.exitStatus in [1,143,137,104,134,139] ? 'retry' : task.exitStatus in [255] ? 'ignore' : 'finish' }
77+
errorStrategy = { task.exitStatus in [1,143,137,104,134,139, 140] ? 'retry' : task.exitStatus in [255] ? 'ignore' : 'finish' }
7878
}
7979

8080
withName:preseq {
8181
errorStrategy = 'ignore'
8282
}
8383

8484
withName:damageprofiler {
85-
errorStrategy = { task.exitStatus in [1,143,137,104,134,139] ? 'retry' : 'finish' }
85+
errorStrategy = { task.exitStatus in [1,143,137,104,134,139, 140] ? 'retry' : 'finish' }
8686
}
8787

8888
// Add 1 retry for certain java tools as not enough heap space java errors gives exit code 1
8989
withName: dedup {
90-
errorStrategy = { task.exitStatus in [1,143,137,104,134,139] ? 'retry' : 'finish' }
90+
errorStrategy = { task.exitStatus in [1,143,137,104,134,139, 140] ? 'retry' : 'finish' }
9191
}
9292

9393
withName: markduplicates {
94-
errorStrategy = { task.exitStatus in [143,137] ? 'retry' : 'finish' }
94+
errorStrategy = { task.exitStatus in [143,137, 140] ? 'retry' : 'finish' }
9595
}
9696

9797
// Add 1 retry as not enough heapspace java error gives exit code 1
9898
withName: malt {
99-
errorStrategy = { task.exitStatus in [1,143,137,104,134,139] ? 'retry' : 'finish' }
99+
errorStrategy = { task.exitStatus in [1,143,137,104,134,139, 140] ? 'retry' : 'finish' }
100100
}
101101

102102
// other process specific exit statuses
103103
withName: nuclear_contamination {
104-
errorStrategy = { task.exitStatus in [143,137,104,134,139] ? 'ignore' : 'retry' }
104+
errorStrategy = { task.exitStatus in [143,137,104,134,139, 140] ? 'ignore' : 'retry' }
105105
}
106106

107107
}
-1.13 KB
Loading

docs/images/tutorials/profiles/config_profile_inheritence.svg

Lines changed: 9 additions & 9 deletions
Loading

0 commit comments

Comments
 (0)