Skip to content

Commit 8d41bc9

Browse files
authored
Merge pull request #892 from nf-core/patch-testconfig_params_updates
Remove deprecated params from benchmarking profiles
2 parents d2dd49f + a58b829 commit 8d41bc9

3 files changed

Lines changed: 5 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1313
- [#879](https://github.com/nf-core/eager/issues/879) Add missing threads parameter for pre-clipping FastQC for single end data that caused insufficient memory in some cases (♥ to @marcel-keller for reporting)
1414
- [#885](https://github.com/nf-core/eager/issues/885) Specify task memory for all tools in get_software_versions to account for incompatibilty of java with some SGE clusters causing hanging of the process (♥ to @maxibor for reporting)
1515
- [#887](https://github.com/nf-core/eager/issues/887) Clarify what is considered 'ultra-short' reads in the help text of clip_readlength, for when you may wish to turn of length filtering during AdapterRemoval (♥ to @TCLamnidis for reporting)
16+
- [#889](https://github.com/nf-core/eager/issues/889) Remove/updated parameters from benchmarking test profiles (♥ to @TCLamnidis for reporting)
17+
1618

1719
### `Dependencies`
1820

conf/benchmarking_human.config

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,24 @@ params {
1212
config_profile_description = "A 'fullsized' benchmarking profile for deepish Human sequencing aDNA data"
1313

1414
//Input data
15-
input = 'https://raw.githubusercontent.com/jfy133/test-datasets/eager/testdata/Benchmarking/benchmarking_human.tsv'
15+
input = 'https://raw.githubusercontent.com/nf-core/test-datasets/eager/testdata/Benchmarking/benchmarking_human.tsv'
1616
// Genome reference
1717
fasta = 'https://hgdownload.soe.ucsc.edu/goldenPath/hg19/bigZips/hg19.fa.gz'
1818

1919
run_bam_filtering = true
20-
bam_discard_unmapped = true
2120
bam_unmapped_type = 'discard'
2221
bam_mapping_quality_threshold = 30
2322

2423
dedupper = 'markduplicates'
2524

2625
run_trim_bam = true
27-
bamutils_clip_left = 1
28-
bamutils_clip_right = 1
26+
bamutils_clip_double_stranded_none_udg_left = 1
27+
bamutils_clip_double_stranded_none_udg_right = 1
2928

3029
// JAR will need to be downloaded first!
3130
run_genotyping = true
3231
genotyping_tool = 'ug'
3332
genotyping_source = 'trimmed'
34-
gatk_ug_jar = 'GenomeAnalysisTK.jar'
3533
gatk_call_conf = 20
3634

3735
run_sexdeterrmine = true
@@ -41,8 +39,6 @@ params {
4139
contamination_chrom_name = 'chrX'
4240

4341
run_mtnucratio = true
44-
45-
4642
}
4743

4844
process {

conf/benchmarking_vikingfish.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ params {
2020
bwaalnl = 1024
2121

2222
run_bam_filtering = true
23-
bam_discard_unmapped = true
2423
bam_unmapped_type = 'discard'
2524
bam_mapping_quality_threshold = 25
2625

0 commit comments

Comments
 (0)