Skip to content

feat: support Angular Elements#18

Merged
LayZeeDK merged 3 commits into
mainfrom
feat/support-angular-elements
Mar 28, 2021
Merged

feat: support Angular Elements#18
LayZeeDK merged 3 commits into
mainfrom
feat/support-angular-elements

Conversation

@LayZeeDK

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Angular Elements is not replaced if present in package.json.

Issue Number: N/A

What is the new behavior?

Angular Elements is replaced if present in package.json.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@LayZeeDK LayZeeDK requested a review from NachoVazquez March 27, 2021 20:56

@NachoVazquez NachoVazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn build and include the built changes to the PR. We will need those for releasing the new version.

I will add those details to the README or CONTRIBUTE file

@LayZeeDK LayZeeDK requested a review from NachoVazquez March 27, 2021 22:55
@LayZeeDK LayZeeDK merged commit 26ede9e into main Mar 28, 2021
@LayZeeDK LayZeeDK deleted the feat/support-angular-elements branch March 28, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants