feat(builder): swap angular builder based on the angular version#22
Merged
Conversation
NachoVazquez
changed the title
LayZeeDK
requested changes
Apr 9, 2021
NachoVazquez
force-pushed
the
feat/swap-angular-build
branch
from
055ef79 to
b507413
Compare
LayZeeDK
requested changes
Apr 10, 2021
LayZeeDK
reviewed
Apr 18, 2021
| test(`when using the version ${version} it should replace all libraries build builder with ${pre10_1LibraryBuilder}`, () => { | ||
| const actual = replaceLibrariesBuildBuilder(version, mixedAngularJson); | ||
|
|
||
| expect(actual).toEqual(pre10_1LibraryBuilderWorkspace); |
Member
There was a problem hiding this comment.
What I mean is let the test show that the builder name is what's changed. This is not currently clear in the test body, only in the test description. Assert on the builder name of a library build architect target, not the entire workspace configuration.
3 tasks
Contributor
Author
I know what you are saying but the reason I like to do it this way is that it gives me confidence that I'm not changing other target builders that I should not be changing. |
LayZeeDK
requested changes
Apr 20, 2021
LayZeeDK
requested changes
Apr 25, 2021
LayZeeDK
requested changes
Apr 25, 2021
3 tasks
BREAKING CHANGE: 🧨 - input name changed from file-path to root-path - angular builder is modify at the angular.json file depending on the version
Co-authored-by: Lars Gyrup Brink Nielsen <larsbrinknielsen@gmail.com>
LayZeeDK
requested changes
Apr 26, 2021
NachoVazquez
force-pushed
the
feat/swap-angular-build
branch
from
cbfdf5b to
8e1669f
Compare
Co-authored-by: Lars Gyrup Brink Nielsen <larsbrinknielsen@gmail.com>
LayZeeDK
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
yarn build)PR Type
What kind of change does this PR introduce?
What is the current behavior?
The action doesn't support changing the angular builder since only modifies the package.json
Fixes: #20
What is the new behavior?
The angular.json builder is modified depending on the angular version passed as input.
For version below 10.1.x it uses
"@angular-devkit/build-ng-packagr:build"For version greater or equal than 10.1.x it uses
"@angular-devkit/build-angular:ng-packagr"Does this PR introduce a breaking change?
Other information
file-pathis notroot-path, it should be a folder instead of a path, it should be the folder where the package.json and angular.json exist and it defaults to "."