Skip to content

fix: correct Angular 11.0.x versions#23

Merged
NachoVazquez merged 2 commits into
mainfrom
fix/correct-angular-11.0.x-versions
Apr 9, 2021
Merged

fix: correct Angular 11.0.x versions#23
NachoVazquez merged 2 commits into
mainfrom
fix/correct-angular-11.0.x-versions

Conversation

@LayZeeDK

@LayZeeDK LayZeeDK commented Apr 9, 2021

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The latest artifacts are committed (run yarn build)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Someone copy-pasted 11.1.x versions to 11.0.x so that the consumer is getting 11.1.x dependencies when asking for 11.0.x. Someone was also lazy enough to let it slip through the code review 😂

Issue Number: N/A

What is the new behavior?

The consumer gets 11.0.x dependencies when asking for them.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

😂

@LayZeeDK LayZeeDK requested a review from NachoVazquez April 9, 2021 18:00

@NachoVazquez NachoVazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups 💩.

Thank you!

@NachoVazquez NachoVazquez merged commit 61117e4 into main Apr 9, 2021
@NachoVazquez NachoVazquez deleted the fix/correct-angular-11.0.x-versions branch April 9, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants