Skip to content

feat: add support for angular 12-rc and up#24

Merged
NachoVazquez merged 2 commits into
mainfrom
feat/add-ng-12-support
Apr 25, 2021
Merged

feat: add support for angular 12-rc and up#24
NachoVazquez merged 2 commits into
mainfrom
feat/add-ng-12-support

Conversation

@NachoVazquez

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The latest artifacts are committed (run yarn build)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Angular v12 RC and newer is not supported

Issue Number: N/A

What is the new behavior?

Angular v12 RC and newer is not supported

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@santoshyadavdev santoshyadavdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerkanSipahi SerkanSipahi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@NachoVazquez NachoVazquez merged commit 2103e8a into main Apr 25, 2021
@NachoVazquez NachoVazquez deleted the feat/add-ng-12-support branch April 25, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants