Skip to content

feat: remove commonjs-allowed-dependencies on angular version under 10#37

Merged
NachoVazquez merged 4 commits into
mainfrom
feat/remove-allowed-commonjs-dependencies-for-versions-under-10
Oct 22, 2021
Merged

feat: remove commonjs-allowed-dependencies on angular version under 10#37
NachoVazquez merged 4 commits into
mainfrom
feat/remove-allowed-commonjs-dependencies-for-versions-under-10

Conversation

@NachoVazquez

@NachoVazquez NachoVazquez commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The latest artifacts are committed (run yarn build)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The allowedCommonJsDependencies option for the @angular-devkit/build-angular:browser is causing issues with versions under 10 of Angular

Fixes: #34

What is the new behavior?

The allowedCommonJsDependencies option for the @angular-devkit/build-angular:browser is removed for Angular versions under 10

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@NachoVazquez NachoVazquez requested a review from LayZeeDK August 23, 2021 02:55
@NachoVazquez NachoVazquez force-pushed the feat/remove-allowed-commonjs-dependencies-for-versions-under-10 branch 2 times, most recently from 4087765 to 57ee836 Compare August 24, 2021 17:34
Comment thread src/remove-commonjs-allowed-dependencies.ts Outdated
Comment thread src/remove-commonjs-allowed-dependencies.ts Outdated
Comment thread README.md Outdated
@NachoVazquez NachoVazquez force-pushed the feat/remove-allowed-commonjs-dependencies-for-versions-under-10 branch from 57ee836 to 2febb64 Compare September 26, 2021 12:25
@NachoVazquez NachoVazquez requested a review from LayZeeDK October 20, 2021 01:36
@NachoVazquez NachoVazquez merged commit 7e78fb4 into main Oct 22, 2021
@NachoVazquez NachoVazquez deleted the feat/remove-allowed-commonjs-dependencies-for-versions-under-10 branch October 22, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

remove projects[*].architect.build.options.allowedCommonJsDependencies for Angular <10.0

2 participants