Commit 5c37c02
committed
feat!: use strict query params
Array query parameters like `?size=m&size=l&size=xl now correctly resolved to `readonly string[]` instead of `string`.
**BREAKING CHANGES**
`RouterStore#queryParams$` and `MinimalActivatedRouteSnapshot#queryParams` use `StrictQueryParams` instead of `StrictRouteParams`. Members are of type `string | readonly string[] | undefined` instead of `string | undefined`.
The TypeScript compiler will fail to compile code that does not handle the string array type.
BEFORE:
```typescript
// shirts.component.ts
// (...)
import { RouterStore } from "@ngworker/router-component-store";
@component({
// (...)
})
export class ShirtsComponent {
#routerStore = inject(RouterStore);
size$: Observable<string> = this.#routerStore.queryParams$.pipe(
map((params) => params["size"]),
);
}
```
AFTER:
```typescript
// shirts.component.ts
// (...)
import { RouterStore } from "@ngworker/router-component-store";
@component({
// (...)
})
export class ShirtsComponent {
#routerStore = inject(RouterStore);
size$: Observable<readonly string[]> = this.#routerStore.queryParams$.pipe(
map((params) => params["size"]),
map((size) => (Array.isArray(size) ? size : [size]))
);
}
```
`RouterStore#selectQueryParam` use `StrictQueryParams` instead of `StrictRouteParams`. The returned value is of type `string | readonly string[] | undefined` instead of `string | undefined`.
The TypeScript compiler will fail to compile code that does not handle the string array type.
BEFORE:
```typescript
// shirts.component.ts
// (...)
import { RouterStore } from "@ngworker/router-component-store";
@component({
// (...)
})
export class ShirtsComponent {
#routerStore = inject(RouterStore);
size$: Observable<string> = this.#routerStore.selectQueryParam('size');
}
```
AFTER:
```typescript
// shirts.component.ts
// (...)
import { RouterStore } from "@ngworker/router-component-store";
@component({
// (...)
})
export class ShirtsComponent {
#routerStore = inject(RouterStore);
size$: Observable<readonly string[]> = this.#routerStore.selectQueryParam('size').pipe(
map((size) => (Array.isArray(size) ? size : [size]))
);
}
```1 parent 6ac16c9 commit 5c37c02
7 files changed
Lines changed: 41 additions & 12 deletions
File tree
- packages/router-component-store/src
- lib
- @ngrx/router-store
- global-router-store
- local-router-store
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | | - | |
4 | 5 | | |
5 | 6 | | |
6 | | - | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
| 9 | + | |
12 | 10 | | |
13 | 11 | | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
57 | | - | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | | - | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
104 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
105 | 108 | | |
106 | 109 | | |
107 | 110 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
47 | | - | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
90 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
91 | 94 | | |
92 | 95 | | |
93 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | | - | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
83 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments