Skip to content

Commit f02b554

Browse files
MarwaxhelloMarwa
andauthored
feat: added margin to breadcrumb-nav (#2972)
Rich-text tokens Stranger => `"value": "{utrecht.space.block.2xl}"` => 32px Acquaintance => `"value": "{utrecht.space.block.xl}"` => 24px Friend => `"value": "{utrecht.space.block.md}"` => 16px Best-friend => `"value": "{utrecht.space.block.xs}"` => 8px Confidant => `"value": 0` => 0px [Volgens Utrecht Storybook Block Spacing](https://nl-design-system.github.io/utrecht/storybook/?path=/docs/utrecht-design-tokens-space--docs#block-spacing) --------- Co-authored-by: Marwa <marwahello@frameless.io>
1 parent 55988ac commit f02b554

File tree

5 files changed

+23
-3
lines changed

5 files changed

+23
-3
lines changed

.changeset/warm-pianos-type.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@utrecht/breadcrumb-nav-css": minor
3+
"@utrecht/design-tokens": minor
4+
---
5+
6+
Corrected several spacing token values and metadata in the Breadcrumb Navigation and Rich Text components.

components/breadcrumb-nav/src/_mixin.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
font-family: var(--utrecht-document-font-family, inherit);
4242
font-size: var(--utrecht-breadcrumb-nav-font-size);
4343
line-height: var(--utrecht-breadcrumb-nav-line-height);
44+
margin-block-end: var(--utrecht-breadcrumb-nav-margin-block-end);
4445
text-transform: var(--utrecht-document-text-transform, inherit);
4546
}
4647

components/breadcrumb-nav/src/tokens.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,16 @@
9595
},
9696
"type": "spacing"
9797
},
98+
"margin-block-end": {
99+
"$extensions": {
100+
"nl.nldesignsystem.css.property": {
101+
"syntax": "<length>",
102+
"inherits": true
103+
},
104+
"nl.nldesignsystem.figma.supports-token": false
105+
},
106+
"type": "spacing"
107+
},
98108
"padding-inline-end": {
99109
"$extensions": {
100110
"nl.nldesignsystem.css.property": {

proprietary/design-tokens/src/component/utrecht/breadcrumb-nav.tokens.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
"font-size": {
77
"value": "{utrecht.typography.scale.md.font-size}"
88
},
9+
"margin-block-end": {
10+
"value": "{utrecht.space.block.2xl}"
11+
},
912
"text-transform": {},
1013
"divider": {
1114
"inline-size": {

proprietary/design-tokens/src/component/utrecht/rich-text.tokens.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
"margin-block-end": { "value": "{utrecht.space.block.2xl}" }
66
},
77
"acquaintance": {
8-
"margin-block-end": { "value": "{utrecht.space.block.md}" }
8+
"margin-block-end": { "value": "{utrecht.space.block.xl}" }
99
},
1010
"friend": {
11-
"margin-block-end": { "value": "{utrecht.space.block.xs}" }
11+
"margin-block-end": { "value": "{utrecht.space.block.md}" }
1212
},
1313
"best-friend": {
14-
"margin-block-end": { "value": "{utrecht.space.block.2xs}" }
14+
"margin-block-end": { "value": "{utrecht.space.block.xs}" }
1515
},
1616
"confidant": {
1717
"margin-block-end": { "value": 0 }

0 commit comments

Comments
 (0)