Skip to content

Commit 22de063

Browse files
committed
docs: better handle parsing errors in file name
1 parent 557b504 commit 22de063

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ file system.
631631
form.on('fileBegin', (formName, file) => {
632632
// accessible here
633633
// formName the name in the form (<input name="thisname" type="file">)
634-
// file.name (http filename)
634+
// file.name http filename or null if there was a parsing error
635635
// file.path default pathnme as per options.uploadDir and options.filename
636636
// file.path = CUSTOM_PATH // to change the final path
637637
});

examples/with-http.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,18 @@ const server = http.createServer((req, res) => {
88
// parse a file upload
99
const form = formidable({ multiples: true });
1010

11+
form.on("fileBegin", (formName, file) => {
12+
if (file.name === null) {
13+
file.name = "invalid-characters"
14+
}
15+
})
1116
form.parse(req, (err, fields, files) => {
17+
if (err) {
18+
console.error(err);
19+
res.writeHead(400, { 'Content-Type': 'text/plain' });
20+
res.end("Bad Request");
21+
return;
22+
}
1223
res.writeHead(200, { 'Content-Type': 'application/json' });
1324
res.end(JSON.stringify({ fields, files }, null, 2));
1425
});

0 commit comments

Comments
 (0)