metrics: convert file.save from callback to promise (#3794)

trivikr · web-flow · commit 87cdb4201494 · 2024-07-01T15:24:47.000+02:00
diff --git a/ansible/roles/metrics/files/index-generator/index-generator.js b/ansible/roles/metrics/files/index-generator/index-generator.js
@@ -6,7 +6,6 @@ const express = require('express')
 const app = express()
 app.use(express.json())
 
-
 async function getFileList() {
 
       let fileList = []
@@ -34,15 +33,14 @@ async function generateIndex() {
         body += (bodyString)
     }
 
-    indexfile = '<html>\n<head>\n</head>\n<body>\n' + body + '</body>\n</html>'
-
-    storage.bucket('access-logs-summaries-nodejs').file('index.html').save(indexfile, function (err) {
-        if (err) {
-          console.log('ERROR UPLOADING: ', err)
-        } else {
-          console.log('Upload complete')
-        }
-      })
+    const fileContents = '<html>\n<head>\n</head>\n<body>\n' + body + '</body>\n</html>'
+    const fileName = 'index.html'
+    try {
+      await storage.bucket('access-logs-summaries-nodejs').file(fileName).save(fileContents)
+      console.log(`Upload complete: ${fileName}`)
+    } catch (error) {
+      console.error(`ERROR UPLOADING FILE: ${fileName} - ${error}`)
+    }
 }
 
 app.post('/', async (req, res) => {
diff --git a/ansible/roles/metrics/files/summaries/summaries.js b/ansible/roles/metrics/files/summaries/summaries.js
@@ -89,14 +89,15 @@ async function produceSummaries (date) {
   })
   await collectData(date)
   prepare()
-  let outputFile = "nodejs.org-access.log." + date.toString() + ".json"
-  storage.bucket('access-logs-summaries-nodejs').file(outputFile).save(JSON.stringify(counts), function (err) {
-    if (err) {
-      console.log('ERROR UPLOADING: ', err)
-    } else {
-      console.log('Upload complete')
-    }
-  })
+
+  const fileContents = JSON.stringify(counts)
+  const fileName = `nodejs.org-access.log.${date.toString()}.json`
+  try {
+    await storage.bucket('access-logs-summaries-nodejs').file(fileName).save(fileContents)
+    console.log(`Upload complete: ${fileName}`)
+  } catch (error) {
+    console.error(`ERROR UPLOADING FILE: ${fileName} - ${error}`)
+  }
 }
 
 app.post('/', async (req, res) => {
