fix: do not hard fail if Corepack home folder cannot be created (#382)

Author: aduh95

sources/Engine.ts

@@ -21,6 +21,10 @@ export type PreparedPackageManagerInfo = Awaited<ReturnType<Engine[`ensurePackag
 export function getLastKnownGoodFile(flag = `r`) {
   return fs.promises.open(path.join(folderUtils.getCorepackHomeFolder(), `lastKnownGood.json`), flag);
 }
+async function createLastKnownGoodFile() {
+  await fs.promises.mkdir(folderUtils.getCorepackHomeFolder(), {recursive: true});
+  return getLastKnownGoodFile(`w`);
+}
 
 export async function getJSONFileContent(fh: FileHandle) {
   let lastKnownGood: unknown;
@@ -139,17 +143,13 @@ export class Engine {
     if (typeof definition === `undefined`)
       throw new UsageError(`This package manager (${packageManager}) isn't supported by this corepack build`);
 
-    let emptyFile = false;
-    const lastKnownGoodFile = await getLastKnownGoodFile(`r+`).catch(err => {
-      if ((err as NodeError)?.code === `ENOENT`) {
-        emptyFile = true;
-        return getLastKnownGoodFile(`w`);
+    let lastKnownGoodFile = await getLastKnownGoodFile(`r+`).catch(err => {
+      if ((err as NodeError)?.code !== `ENOENT`) {
+        throw err;
       }
-
-      throw err;
     });
     try {
-      const lastKnownGood = emptyFile || await getJSONFileContent(lastKnownGoodFile);
+      const lastKnownGood = lastKnownGoodFile == null || await getJSONFileContent(lastKnownGoodFile!);
       const lastKnownGoodForThisPackageManager = getLastKnownGoodFromFileContent(lastKnownGood, packageManager);
       if (lastKnownGoodForThisPackageManager)
         return lastKnownGoodForThisPackageManager;
@@ -159,14 +159,20 @@ export class Engine {
 
       const reference = await corepackUtils.fetchLatestStableVersion(definition.fetchLatestFrom);
 
-      await activatePackageManagerFromFileHandle(lastKnownGoodFile, lastKnownGood, {
-        name: packageManager,
-        reference,
-      });
+      try {
+        lastKnownGoodFile ??= await createLastKnownGoodFile();
+        await activatePackageManagerFromFileHandle(lastKnownGoodFile, lastKnownGood, {
+          name: packageManager,
+          reference,
+        });
+      } catch {
+        // If for some reason, we cannot update the last known good file, we
+        // ignore the error.
+      }
 
       return reference;
     } finally {
-      await lastKnownGoodFile.close();
+      await lastKnownGoodFile?.close();
     }
   }
 

tests/main.test.ts

@@ -739,3 +739,22 @@ it(`should show a warning on stderr before downloading when enable`, async() =>
     });
   });
 });
+
+it(`should be able to show the latest version`, async () => {
+  process.env.COREPACK_DEFAULT_TO_LATEST = `1`;
+  await xfs.mktempPromise(async cwd => {
+    await expect(runCli(cwd, [`yarn`, `--version`])).resolves.toMatchObject({
+      exitCode: 0,
+      stdout: /^1\.\d+\.\d+\r?\n$/,
+      stderr: ``,
+    });
+
+    // Should keep working if the home folder is removed
+    await xfs.rmdirPromise(process.env.COREPACK_HOME as any, {recursive: true});
+    await expect(runCli(cwd, [`yarn`, `--version`])).resolves.toMatchObject({
+      exitCode: 0,
+      stdout: /^1\.\d+\.\d+\r?\n$/,
+      stderr: ``,
+    });
+  });
+});