Commit 0e35ab8
authored
feat: add VCToolsVersion for msvs (#209)
* Add the ability to specify the 'MSVC toolset version' <VCToolsVersion> for the VisualStudio platform.
Usage example for binding.gyp
```
'targets': [
{
'configurations': {
'Debug': {
"msvs_configuration_attributes": {
"VCToolsVersion": "14.36.32532",
```
* chore: update build-windows runs-on to windows-latest
extract from comments by PR #209:add VCToolsVersion for msvs
```
The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019.
However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022.
Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest.
```1 parent 98da389 commit 0e35ab8
3 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| |||
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
103 | | - | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3004 | 3004 | | |
3005 | 3005 | | |
3006 | 3006 | | |
| 3007 | + | |
3007 | 3008 | | |
3008 | 3009 | | |
3009 | 3010 | | |
| |||
3019 | 3020 | | |
3020 | 3021 | | |
3021 | 3022 | | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
3022 | 3027 | | |
3023 | 3028 | | |
3024 | 3029 | | |
| |||
3100 | 3105 | | |
3101 | 3106 | | |
3102 | 3107 | | |
| 3108 | + | |
| 3109 | + | |
3103 | 3110 | | |
3104 | 3111 | | |
3105 | 3112 | | |
| |||
0 commit comments