fix(backport): checkout from staging branch and ask to update if needed#732
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 37 37
Lines 4178 4178
=======================================
Hits 3469 3469
Misses 709 709 ☔ View full report in Codecov by Sentry. |
rluvaton
force-pushed
the
allow-syncing-staging-branch-before-backporting
branch
from
ab01c09 to
ef56f71
Compare
| cli.SPINNER_STATUS.WARN); | ||
| continue; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Unrelated style change? (I'm surprised we don't lint these files.)
There was a problem hiding this comment.
(Although, yeah, that semicolon shouldn't be there. Maybe leave it and ignore my comment. But uh, future enhancement for someone: Add linting or adjust the current linting to catch that stuff automatically.)
|
Is it reasonable to add a test for this change? (Non-blocking but of course I'd prefer a test to not having test if it's not too onerous.) |
|
I totally with you on adding test but there where no test to begin with I will try to add one... |
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Please do not hard code 'upstream', and take the name of the upstream from the config instead.
rluvaton
force-pushed
the
allow-syncing-staging-branch-before-backporting
branch
from
ef56f71 to
e8a3095
Compare
@aduh95 fixed |
rluvaton
deleted the
allow-syncing-staging-branch-before-backporting
branch
4 participants
Fixes #731
this aligns with steps 1-3 in
doc/contributing/backporting-to-release-lines.md- How to submit a backport pull requesthttps://github.com/nodejs/node/blob/c2cd74453e7d2794ad81cab63e68371e08bad04f/doc/contributing/backporting-to-release-lines.md?plain=1#L48-L62