inspector: convert a header object to a simple string dictionary

Author: cola119

lib/internal/inspector_network_tracking.js

@@ -1,7 +1,9 @@
 'use strict';
 
 const {
+  ArrayIsArray,
   DateNow,
+  ObjectEntries,
 } = primordials;
 
 let dc;
@@ -10,6 +12,17 @@ let Network;
 let requestId = 0;
 const getNextRequestId = () => `node-network-event-${++requestId}`;
 
+// Convert a Headers object (Map<string, number | string | string[]>) to a plain object (Map<string, string>)
+const headerObjectToDictionary = (headers = {}) => {
+  const dict = {};
+  for (const { 0: key, 1: value } of ObjectEntries(headers)) {
+    if (typeof value === 'string') dict[key] = value;
+    if (ArrayIsArray(value)) dict[key] = value.join(', ');
+    else dict[key] = value.toString();
+  }
+  return dict;
+};
+
 function onClientRequestStart({ request }) {
   const url = `${request.protocol}//${request.host}${request.path}`;
   const wallTime = DateNow();
@@ -22,7 +35,7 @@ function onClientRequestStart({ request }) {
     request: {
       url,
       method: request.method,
-      headers: request.getHeaders(),
+      headers: headerObjectToDictionary(request.getHeaders()),
     },
   });
 }
@@ -41,7 +54,7 @@ function onClientResponseFinish({ request, response }) {
       url,
       status: response.statusCode,
       statusText: response.statusMessage ?? '',
-      headers: response.headers,
+      headers: headerObjectToDictionary(response.headers),
     },
   });
   Network.loadingFinished({

test/parallel/test-inspector-network-domain.js

@@ -53,6 +53,9 @@ const testHttpGet = () => new Promise((resolve, reject) => {
     assert.strictEqual(params.request.url, 'http://127.0.0.1/hello-world');
     assert.strictEqual(params.request.method, 'GET');
     assert.strictEqual(typeof params.request.headers, 'object');
+    assert.strictEqual(params.request.headers['accept-language'], 'en-US');
+    assert.strictEqual(params.request.headers.cookie, 'k1=v1, k2=v2');
+    assert.strictEqual(params.request.headers.age, '1000');
     assert.strictEqual(typeof params.timestamp, 'number');
     assert.strictEqual(typeof params.wallTime, 'number');
   }));
@@ -75,6 +78,11 @@ const testHttpGet = () => new Promise((resolve, reject) => {
     host: '127.0.0.1',
     port: httpServer.address().port,
     path: '/hello-world',
+    headers: {
+      'accept-language': 'en-US',
+      'cookie': ['k1=v1', 'k2=v2'],
+      'age': 1000
+    }
   }, common.mustCall());
 });
 
@@ -84,6 +92,9 @@ const testHttpsGet = () => new Promise((resolve, reject) => {
     assert.strictEqual(params.request.url, 'https://127.0.0.1/hello-world');
     assert.strictEqual(params.request.method, 'GET');
     assert.strictEqual(typeof params.request.headers, 'object');
+    assert.strictEqual(params.request.headers['accept-language'], 'en-US');
+    assert.strictEqual(params.request.headers.cookie, 'k1=v1, k2=v2');
+    assert.strictEqual(params.request.headers.age, '1000');
     assert.strictEqual(typeof params.timestamp, 'number');
     assert.strictEqual(typeof params.wallTime, 'number');
   }));
@@ -107,6 +118,11 @@ const testHttpsGet = () => new Promise((resolve, reject) => {
     port: httpsServer.address().port,
     path: '/hello-world',
     rejectUnauthorized: false,
+    headers: {
+      'accept-language': 'en-US',
+      'cookie': ['k1=v1', 'k2=v2'],
+      'age': 1000
+    }
   }, common.mustCall());
 });