lib: improve AbortController creation duration

anonrig · anonrig · commit 29fa2dacd25e · 2023-01-03T11:30:22.000-05:00
PR-URL: #45525 Backport-PR-URL: #46078 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -318,6 +318,8 @@ function validateAbortController(obj) {
 }
 
 class AbortController {
+  #signal;
+
   constructor() {
     this[kSignal] = createAbortSignal();
   }
@@ -327,15 +329,16 @@ class AbortController {
    */
   get signal() {
     validateAbortController(this);
-    return this[kSignal];
+    this.#signal ??= createAbortSignal();
+    return this.#signal;
   }
 
   /**
    * @param {any} reason
    */
   abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
     validateAbortController(this);
-    abortSignal(this[kSignal], reason);
+    abortSignal(this.#signal ??= createAbortSignal(), reason);
   }
 
   [customInspectSymbol](depth, options) {

Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,8 @@ function validateAbortController(obj) {`
`318`	`318`	`}`
`319`	`319`
`320`	`320`	`class AbortController {`
	`321`	`+ #signal;`
	`322`	`+`
`321`	`323`	`constructor() {`
`322`	`324`	`this[kSignal] = createAbortSignal();`
`323`	`325`	`}`
`@@ -327,15 +329,16 @@ class AbortController {`
`327`	`329`	`*/`
`328`	`330`	`get signal() {`
`329`	`331`	`validateAbortController(this);`
`330`		`- return this[kSignal];`
	`332`	`+ this.#signal ??= createAbortSignal();`
	`333`	`+ return this.#signal;`
`331`	`334`	`}`
`332`	`335`
`333`	`336`	`/**`
`334`	`337`	`* @param {any} reason`
`335`	`338`	`*/`
`336`	`339`	`abort(reason = new DOMException('This operation was aborted', 'AbortError')) {`
`337`	`340`	`validateAbortController(this);`
`338`		`- abortSignal(this[kSignal], reason);`
	`341`	`+ abortSignal(this.#signal ??= createAbortSignal(), reason);`
`339`	`342`	`}`
`340`	`343`
`341`	`344`	`[customInspectSymbol](depth, options) {`