test_runner: set the properties inside of the error method

This improves the error recreation performance due to limiting the
stack trace that is generated and it makes sure NodeErrors only set
properties inside of the actual error method.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Author: BridgeAR

lib/internal/errors.js

@@ -1529,7 +1529,7 @@ E('ERR_TAP_VALIDATION_ERROR', function(errorMsg) {
   hideInternalStackFrames(this);
   return errorMsg;
 }, Error);
-E('ERR_TEST_FAILURE', function(error, failureType) {
+E('ERR_TEST_FAILURE', function(error, failureType, extraProperties = undefined) {
   hideInternalStackFrames(this);
   assert(typeof failureType === 'string',
          "The 'failureType' argument must be of type string.");
@@ -1542,6 +1542,9 @@ E('ERR_TEST_FAILURE', function(error, failureType) {
 
   this.failureType = failureType;
   this.cause = error;
+  if (extraProperties !== undefined) {
+    ObjectAssign(this, extraProperties);
+  }
   return msg;
 }, Error);
 E('ERR_TLS_CERT_ALTNAME_FORMAT', 'Invalid subject alternative name string',

lib/internal/test_runner/runner.js

@@ -10,7 +10,6 @@ const {
   ArrayPrototypeSort,
   FunctionPrototypeCall,
   Number,
-  ObjectAssign,
   ObjectKeys,
   PromisePrototypeThen,
   SafePromiseAllReturnVoid,
@@ -32,6 +31,7 @@ const {
   codes: {
     ERR_TEST_FAILURE,
   },
+  setStackTraceLimit,
 } = require('internal/errors');
 const { validateArray, validateBoolean } = require('internal/validators');
 const { getInspectPort, isUsingInspector, isInspectorMessage } = require('internal/util/inspector');
@@ -306,16 +306,14 @@ function runTestFile(path, root, inspectPort, filesWatcher) {
     if (code !== 0 || signal !== null) {
       if (!err) {
         const failureType = subtest.failedSubtests ? kSubtestsFailed : kTestCodeFailure;
-        // TODO(BridgeAR): The stack should not be created in the first place
-        // and the properties should be set inside of the function.
-        err = ObjectAssign(new ERR_TEST_FAILURE('test failed', failureType), {
+        const { stackTraceLimit } = Error;
+        setStackTraceLimit(0);
+        err = new ERR_TEST_FAILURE('test failed', failureType, {
           __proto__: null,
           exitCode: code,
           signal: signal,
-          // The stack will not be useful since the failures came from tests
-          // in a child process.
-          stack: undefined,
         });
+        setStackTraceLimit(stackTraceLimit);
       }
 
       throw err;

lib/internal/test_runner/yaml_to_js.js

@@ -3,6 +3,7 @@ const {
   codes: {
     ERR_TEST_FAILURE,
   },
+  setStackTraceLimit,
 } = require('internal/errors');
 const AssertionError = require('internal/assert/assertion_error');
 const {
@@ -32,6 +33,8 @@ function reConstructError(parsedYaml) {
   const stack = parsedYaml.stack ? kStackDelimiter + ArrayPrototypeJoin(parsedYaml.stack, `\n${kStackDelimiter}`) : '';
   let error, cause;
 
+  const { stackTraceLimit } = Error;
+  setStackTraceLimit(0);
   if (isAssertionError) {
     cause = new AssertionError({
       message: parsedYaml.error,
@@ -50,6 +53,7 @@ function reConstructError(parsedYaml) {
     error = new ERR_TEST_FAILURE(cause, parsedYaml.failureType);
     error.stack = stack;
   }
+  setStackTraceLimit(stackTraceLimit);
 
   parsedYaml.error = error ?? cause;
   delete parsedYaml.stack;