module: return correct exports from linked binding

Phillip Kovalev · bnoordhuis · commit 5c14efbbe91b · 2016-02-20T12:48:47.000+01:00
Method `LinkedBinding` must return the same "exports" property of the module as cached, because property can be overridden by an initialization function. PR-URL: #5337 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/src/node.cc b/src/node.cc
@@ -2450,9 +2450,10 @@ static void LinkedBinding(const FunctionCallbackInfo<Value>& args) {
     return env->ThrowError("Linked module has no declared entry point.");
   }
 
-  cache->Set(module_name, module->Get(exports_prop));
+  auto effective_exports = module->Get(exports_prop);
+  cache->Set(module_name, effective_exports);
 
-  args.GetReturnValue().Set(exports);
+  args.GetReturnValue().Set(effective_exports);
 }
 
 static void ProcessTitleGetter(Local<String> property,

Original file line number	Diff line number	Diff line change
`@@ -2450,9 +2450,10 @@ static void LinkedBinding(const FunctionCallbackInfo<Value>& args) {`
`2450`	`2450`	`return env->ThrowError("Linked module has no declared entry point.");`
`2451`	`2451`	`}`
`2452`	`2452`
`2453`		`- cache->Set(module_name, module->Get(exports_prop));`
	`2453`	`+ auto effective_exports = module->Get(exports_prop);`
	`2454`	`+ cache->Set(module_name, effective_exports);`
`2454`	`2455`
`2455`		`- args.GetReturnValue().Set(exports);`
	`2456`	`+ args.GetReturnValue().Set(effective_exports);`
`2456`	`2457`	`}`
`2457`	`2458`
`2458`	`2459`	`static void ProcessTitleGetter(Local<String> property,`