use ObjectDefineProperty

Author: rluvaton

lib/internal/test_runner/test.js

@@ -20,6 +20,7 @@ const {
   SafeSet,
   SafePromiseAll,
   SafePromiseRace,
+  ObjectDefineProperty,
   Symbol,
 } = primordials;
 const { AsyncResource } = require('async_hooks');
@@ -79,7 +80,13 @@ function stopTest(timeout, signal) {
 
   if (timeout === kDefaultTimeout) {
     signal.addEventListener('abort', deferred.resolve, { __proto__: null, once: true });
-    deferred.cleanup = () => signal.removeEventListener('abort', deferred.resolve);
+
+    ObjectDefineProperty(deferred, 'cleanup', {
+      __proto__: null,
+      configurable: true,
+      writable: true,
+      value: () => signal.removeEventListener('abort', deferred.resolve),
+    });
 
     return deferred;
   }
@@ -97,17 +104,27 @@ function stopTest(timeout, signal) {
     clearTimeout(timer);
   }
 
-  deferred.promise = PromisePrototypeThen(deferred.promise, () => {
-    throw new ERR_TEST_FAILURE(
-      `test timed out after ${timeout}ms`,
-      kTestTimeoutFailure,
-    );
+  ObjectDefineProperty(deferred, 'promise', {
+    __proto__: null,
+    configurable: true,
+    writable: true,
+    value: PromisePrototypeThen(deferred.promise, () => {
+      throw new ERR_TEST_FAILURE(
+        `test timed out after ${timeout}ms`,
+        kTestTimeoutFailure,
+      );
+    }),
   });
 
-  deferred.cleanup = () => {
-    clearTimeout(timer);
-    cleanAbort();
-  };
+  ObjectDefineProperty(deferred, 'cleanup', {
+    __proto__: null,
+    configurable: true,
+    writable: true,
+    value: () => {
+      clearTimeout(timer);
+      cleanAbort();
+    },
+  });
 
   return deferred;
 }