fixup

Author: jazelly

lib/internal/webidl.js

@@ -2,7 +2,7 @@
 
 const {
   ArrayPrototypePush,
-  ArrayPrototypeSort,
+  ArrayPrototypeToSorted,
   MathAbs,
   MathMax,
   MathMin,
@@ -267,15 +267,9 @@ function type(V) {
 // https://webidl.spec.whatwg.org/#js-dictionary
 function createDictionaryConverter(members) {
   // The spec requires us to operate the members of a dictionary in
-  // lexicographical order. We are doing all of these in the outer scope to
+  // lexicographical order. We are doing this in the outer scope to
   // reduce the overhead that could happen in the returned function.
-  const sortedMembers = [];
-  for (let i = 0; i < members.length; i++) {
-    const member = members[i];
-    ArrayPrototypePush(sortedMembers, member);
-  }
-
-  ArrayPrototypeSort(sortedMembers, (a, b) => {
+  const sortedMembers = ArrayPrototypeToSorted(members, (a, b) => {
     if (a.key === b.key) {
       return 0;
     }
@@ -287,7 +281,7 @@ function createDictionaryConverter(members) {
     opts = kEmptyObject,
   ) {
     const typeV = type(V);
-    if (typeV !== 'Undefined' && typeV !== 'Null' && typeV !== 'Object') {
+    if (V !== undefined && V !== null && typeV !== 'Object') {
       throw makeException(
         'can not be converted to a dictionary',
         opts,
@@ -299,7 +293,7 @@ function createDictionaryConverter(members) {
       const member = sortedMembers[i];
       const key = member.key;
       let jsMemberValue;
-      if (typeV === 'Undefined' || typeV === 'Null') {
+      if (V == null) {
         jsMemberValue = undefined;
       } else {
         jsMemberValue = V[key];