Skip to content

Commit b5e3fca

Browse files
committed
build: set --v8-enable-object-print by default
The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: #32834 PR-URL: #34705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 3b84048 commit b5e3fca

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

common.gypi

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@
5454
# Enable disassembler for `--print-code` v8 options
5555
'v8_enable_disassembler': 1,
5656

57+
# Sets -dOBJECT_PRINT.
58+
'v8_enable_object_print%': 1,
59+
5760
# https://github.com/nodejs/node/pull/22920/files#r222779926
5861
'v8_enable_handle_zapping': 0,
5962

configure.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@
709709
parser.add_option('--v8-enable-object-print',
710710
action='store_true',
711711
dest='v8_enable_object_print',
712-
default=False,
712+
default=True,
713713
help='compile V8 with auxiliar functions for native debuggers')
714714

715715
parser.add_option('--node-builtin-modules-path',

0 commit comments

Comments
 (0)