lib: use non-symbols in isURLInstance check

codebytere · codebytere · commit d0efaf2fe337 · 2020-08-09T15:04:52.000-07:00
PR-URL: #34622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1391,8 +1391,7 @@ function pathToFileURL(filepath) {
 }
 
 function isURLInstance(fileURLOrPath) {
-  return fileURLOrPath != null && fileURLOrPath[searchParams] &&
-    fileURLOrPath[searchParams][searchParams];
+  return fileURLOrPath != null && fileURLOrPath.href && fileURLOrPath.origin;
 }
 
 function toPathIfFileURL(fileURLOrPath) {

Original file line number	Diff line number	Diff line change
`@@ -1391,8 +1391,7 @@ function pathToFileURL(filepath) {`
`1391`	`1391`	`}`
`1392`	`1392`
`1393`	`1393`	`function isURLInstance(fileURLOrPath) {`
`1394`		`- return fileURLOrPath != null && fileURLOrPath[searchParams] &&`
`1395`		`- fileURLOrPath[searchParams][searchParams];`
	`1394`	`+ return fileURLOrPath != null && fileURLOrPath.href && fileURLOrPath.origin;`
`1396`	`1395`	`}`
`1397`	`1396`
`1398`	`1397`	`function toPathIfFileURL(fileURLOrPath) {`