Commit fd8ac56
v8: fix build errors with g++ 6.1.1
Shifting a negative constant value is no longer allowed unless
the -fpermissive flag is in effect. Fixes the following build
errors:
../deps/v8/src/objects.h:5188:47: warning: left shift of negative value [-Wshift-negative-value]
static const int kElementsKindMask = (-1 << kElementsKindShift) &
../deps/v8/src/objects.h:5188:44: error: left operand of shift expression '(-1 << 3)' is negative [-fpermissive]
static const int kElementsKindMask = (-1 << kElementsKindShift) &
../deps/v8/src/objects.h:7376:39: warning: left shift of negative value [-Wshift-negative-value]
(~kMaxCachedArrayIndexLength << kArrayIndexHashLengthShift) |
../deps/v8/src/objects.h:7376:36: error: left operand of shift expression '(-8 << 26)' is negative [-fpermissive]
(~kMaxCachedArrayIndexLength << kArrayIndexHashLengthShift) |
And:
../deps/v8/src/liveedit.cc:205:44: warning: left shift of negative value [-Wshift-negative-value]
static const int kEmptyCellValue = -1 << kDirectionSizeBits;
../deps/v8/src/liveedit.cc:205:41: error: left operand of shift expression '(-1 << 2)' is negative [-fpermissive]
static const int kEmptyCellValue = -1 << kDirectionSizeBits;
PR-URL: nodejs-private/node-private#62
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent 0d7e21e commit fd8ac56
3 files changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
| 206 | + | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5185 | 5185 | | |
5186 | 5186 | | |
5187 | 5187 | | |
5188 | | - | |
| 5188 | + | |
| 5189 | + | |
5189 | 5190 | | |
5190 | 5191 | | |
5191 | 5192 | | |
| |||
7373 | 7374 | | |
7374 | 7375 | | |
7375 | 7376 | | |
7376 | | - | |
7377 | | - | |
| 7377 | + | |
| 7378 | + | |
7378 | 7379 | | |
7379 | 7380 | | |
7380 | 7381 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
0 commit comments