A few optimizations for Turborepo setup.

Author: anthonyshew

.github/workflows/lint-and-tests.yml

@@ -32,23 +32,13 @@ jobs:
   base:
     name: Base Tasks
     runs-on: ubuntu-latest
-    outputs:
-      turbo_args: ${{ steps.turborepo_arguments.outputs.turbo_args }}
 
     steps:
       - name: Harden Runner
         uses: step-security/harden-runner@63c24ba6bd7ba022e95695ff85de572c04a18142 # v2.7.0
         with:
           egress-policy: audit
 
-      - name: Provide Turborepo Arguments
-        # This step is responsible for providing a reusable string that can be used within other steps and jobs
-        # that use the `turbo` cli command as a way of easily providing shared arguments to the `turbo` command
-        id: turborepo_arguments
-        # See https://turbo.build/repo/docs/reference/command-line-reference/run#--cache-dir
-        # See https://turbo.build/repo/docs/reference/command-line-reference/run#--force
-        run: echo "turbo_args=--force=true --cache-dir=.turbo/cache" >> "$GITHUB_OUTPUT"
-
   lint:
     # This Job should run either on `merge_groups` or `push` events
     # or `pull_request_target` event with a `labeled` action with a label named `github_actions:pull-request`
@@ -60,7 +50,7 @@ jobs:
       (github.event_name == 'pull_request_target' &&
         github.event.label.name == 'github_actions:pull-request')
 
-    name: Lint
+    name: Quality checks
     runs-on: ubuntu-latest
     needs: [base]
 
@@ -116,8 +106,8 @@ jobs:
         # We also use `npm i` instead of `npm ci` so that the node_modules/.cache folder doesn't get deleted
         run: npm i --no-audit --no-fund --ignore-scripts --userconfig=/dev/null
 
-      - name: Run `turbo lint`
-        id: eslint-step
+      - name: Run quality checks with `turbo`
+        id: quality-checks
         # We run the ESLint and Prettier commands on all Workflow triggers of the `Lint` job, besides if
         # the Pull Request comes from a Crowdin Branch, as we don't want to run ESLint and Prettier on Crowdin PRs
         # Note: Linting and Prettifying of files on Crowdin PRs is handled by the `translations-pr.yml` Workflow
@@ -127,13 +117,7 @@ jobs:
             github.event.pull_request.head.ref != 'chore/crowdin')
         # We want to enforce that the actual `turbo@latest` package is used instead of a possible hijack from the user
         # the `${{ needs.base.outputs.turbo_args }}` is a string substitution happening from the base job
-        run: npx --package=turbo@latest -- turbo lint ${{ needs.base.outputs.turbo_args }}
-
-      - name: Run `turbo prettier`
-        if: steps.eslint-step.outcome == 'success'
-        # We want to enforce that the actual `turbo@latest` package is used instead of a possible hijack from the user
-        # the `${{ needs.base.outputs.turbo_args }}` is a string substitution happening from the base job
-        run: npx --package=turbo@latest -- turbo prettier ${{ needs.base.outputs.turbo_args }}
+        run: npx --package=turbo@latest -- turbo lint:js lint:md lint:css prettier test:unit:ci  --cache-dir=.turbo/cache
 
       - name: Run `tsc build`
         # We want to ensure that the whole codebase is passing and successfully compiles with TypeScript

package.json

@@ -23,7 +23,7 @@
     "lint:js": "eslint \"**/*.{js,mjs,ts,tsx}\" --cache --cache-strategy=content --cache-location=.eslintjscache",
     "lint:md": "eslint \"**/*.md?(x)\" --cache --cache-strategy=content --cache-location=.eslintmdcache",
     "lint:css": "stylelint \"**/*.css\" --allow-empty-input --cache --cache-strategy=content --cache-location=.stylelintcache",
-    "lint": "npm run lint:js && npm run lint:md && npm run lint:css",
+    "lint": "turbo run lint:md lint:js lint:css",
     "lint:fix": "npm run lint:js -- --fix && npm run lint:md -- --fix && npm run lint:css -- --fix",
     "prettier": "prettier \"**/*.{js,mjs,ts,tsx,md,mdx,json,yml,css}\" --check --cache --cache-strategy=content --cache-location=.prettiercache",
     "prettier:fix": "npm run prettier -- --write",
@@ -33,7 +33,6 @@
     "storybook:build": "cross-env NODE_NO_WARNINGS=1 storybook build --quiet --webpack-stats-json",
     "test:unit": "cross-env NODE_NO_WARNINGS=1 jest",
     "test:unit:watch": "npm run test:unit -- --watch",
-    "test": "npm run test:unit",
     "prepare": "husky"
   },
   "dependencies": {

turbo.json

@@ -83,27 +83,31 @@
       ]
     },
     "lint:js": {
-      "cache": false,
+      "inputs": [
+        "!styles/**/*.css",
+        "!components/**/*.css",
+        "!layouts/**/*.css",
+        "!*.md",
+        "!pages/**/*.{md,mdx}"
+      ],
       "outputs": [".eslintjscache"]
     },
     "lint:md": {
-      "cache": false,
+      "inputs": ["*.md", "pages/**/*.{md,mdx}"],
       "outputs": [".eslintmdcache"]
     },
     "lint:css": {
-      "cache": false,
+      "inputs": ["styles/**/*.css", "components/**/*.css", "layouts/**/*.css"],
       "outputs": [".stylelintcache"]
     },
     "lint": {
-      "cache": false,
       "outputs": [".eslintjscache", ".eslintmdcache", ".stylelintcache"]
     },
     "lint:fix": {
       "cache": false,
       "outputs": [".eslintjscache", ".eslintmdcache", ".stylelintcache"]
     },
     "prettier": {
-      "cache": false,
       "outputs": [".prettiercache"]
     },
     "prettier:fix": {