fix: fetch redirect modes

Author: ronag

README.md

@@ -182,7 +182,7 @@ https://fetch.spec.whatwg.org/#request-class
 * **mode** *not supported*
 * **credentials** *not supported*
 * **cache** *not supported*
-* **redirect** `RequestRedirect` *only `"follow"` supported*
+* **redirect** `RequestRedirect`
 * **integrity** *not supported*
 * **keepalive** *not supported*
 * **signal** `AbortSignal?`

lib/api/api-fetch.js

@@ -23,18 +23,18 @@ const kHeaders = Symbol('headers')
 
 class Response extends Body {
   constructor ({
-    type = 'default',
+    type,
     url,
     resume,
     abort,
-    statusCode = 0,
+    statusCode,
     headers,
     context
   }) {
     super(resume, abort)
 
-    this[kType] = type
-    this[kStatus] = statusCode
+    this[kType] = type || 'default'
+    this[kStatus] = statusCode || 0
     this[kUrlList] = [url]
     this[kHeaders] = headers
 
@@ -160,15 +160,21 @@ class FetchHandler extends AsyncResource {
           type: 'opaqueredirect',
           url: this.url
         })
+        // TODO (fix): Should be "null" body.
+        // TODO (fix): What to do with Readable?
+        util.destroy(body)
       } else {
         body = new Response({
           type: 'error',
           url: this.url
         })
+        // TODO (fix): Should be "null" body.
+        // TODO (fix): What to do with Readable?
         util.destroy(body, new Error('redirect'))
       }
     } else {
       body = new Response({
+        type: 'default',
         url: this.url,
         resume,
         abort,
@@ -260,20 +266,21 @@ function fetch (opts, callback) {
       throw new NotSupportedError()
     }
 
-    if (
-      opts.redirect !== undefined &&
-      opts.redirect !== 'follow' &&
-      opts.redirect !== 'error'
-    ) {
-      // TODO: Implement
-      throw new NotSupportedError()
+    if (opts.redirect != null) {
+      // TODO: Validate
+    } else {
+      opts.redirect = 'follow'
     }
 
     if (opts.integrity) {
       // TODO: Implement
       throw new NotSupportedError()
     }
 
+    if (opts.keepalive) {
+      // Ignore
+    }
+
     const headers = new Headers(opts.headers)
 
     if (!headers.has('accept')) {
@@ -297,7 +304,7 @@ function fetch (opts, callback) {
       method: normalizeAndValidateRequestMethod(opts.method || 'GET'),
       body,
       headers: headers ? (headers[kHeadersList] || headers) : null,
-      maxRedirections: 20 // https://fetch.spec.whatwg.org/#concept-http-redirect-fetch
+      maxRedirections: opts.redirect === 'follow' ? 20 : 0 // https://fetch.spec.whatwg.org/#concept-http-redirect-fetch
     }, new FetchHandler(opts, callback))
   } catch (err) {
     if (typeof callback !== 'function') {