Throw if connection header is specified (#271)

* Ignore connection header

* Throw if connection header is passed in

Author: mcollina

lib/request.js

@@ -117,6 +117,11 @@ class Request extends AsyncResource {
             key.toLowerCase() === 'transfer-encoding'
           ) {
             throw new InvalidArgumentError('invalid transfer-encoding header')
+          } else if (
+            key.length === 10 &&
+            key.toLowerCase() === 'connection'
+          ) {
+            throw new InvalidArgumentError('invalid connection header')
           } else {
             header += `${key}: ${val}\r\n`
           }

test/http-100.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const { test } = require('tap')
-const { Client, errors } = require('..')
+const { Client } = require('..')
 const { createServer } = require('http')
 const net = require('net')
 
@@ -36,36 +36,6 @@ test('ignore informational response', (t) => {
   })
 })
 
-test('error 101', (t) => {
-  t.plan(2)
-
-  const server = net.createServer((socket) => {
-    socket.write('HTTP/1.1 101 Switching Protocols\r\n')
-    socket.write('Upgrade: TLS/1.0, HTTP/1.1\r\n')
-    socket.write('Connection: Upgrade\r\n')
-    socket.write('\r\n')
-  })
-  t.teardown(server.close.bind(server))
-  server.listen(0, () => {
-    const client = new Client(`http://localhost:${server.address().port}`)
-    t.teardown(client.destroy.bind(client))
-
-    client.request({
-      path: '/',
-      method: 'GET',
-      headers: {
-        Connection: 'upgrade',
-        Upgrade: 'example/1, foo/2'
-      }
-    }, (err) => {
-      t.ok(err instanceof errors.NotSupportedError)
-    })
-    client.on('disconnect', () => {
-      t.pass()
-    })
-  })
-})
-
 test('error 103 body', (t) => {
   t.plan(2)
 

test/invalid-headers.js

@@ -4,7 +4,7 @@ const { test } = require('tap')
 const { Client, errors } = require('..')
 
 test('invalid headers', (t) => {
-  t.plan(4)
+  t.plan(5)
 
   const client = new Client('http://localhost:3000')
   t.teardown(client.destroy.bind(client))
@@ -28,6 +28,16 @@ test('invalid headers', (t) => {
     t.ok(err instanceof errors.InvalidArgumentError)
   })
 
+  client.request({
+    path: '/',
+    method: 'GET',
+    headers: {
+      connection: 'close'
+    }
+  }, (err, data) => {
+    t.ok(err instanceof errors.InvalidArgumentError)
+  })
+
   client.request({
     path: '/',
     method: 'GET',