fix(builtins): move to generated node builtins fixture (#157)

This generates the node builtins from runtime instead of using pulling
them from the runtime. It will allow this to work in a browser setting
with no resolve fallbacks needing to be added.

Author: wraithgar

lib/builtin-modules.json

@@ -0,0 +1 @@
+["_http_agent","_http_client","_http_common","_http_incoming","_http_outgoing","_http_server","_stream_duplex","_stream_passthrough","_stream_readable","_stream_transform","_stream_wrap","_stream_writable","_tls_common","_tls_wrap","assert","assert/strict","async_hooks","buffer","child_process","cluster","console","constants","crypto","dgram","diagnostics_channel","dns","dns/promises","domain","events","fs","fs/promises","http","http2","https","inspector","inspector/promises","module","net","os","path","path/posix","path/win32","perf_hooks","process","punycode","querystring","readline","readline/promises","repl","stream","stream/consumers","stream/promises","stream/web","string_decoder","sys","timers","timers/promises","tls","trace_events","tty","url","util","util/types","v8","vm","wasi","worker_threads","zlib","node:sea","node:sqlite","node:test","node:test/reporters"]

lib/index.js

@@ -1,5 +1,5 @@
 'use strict'
-const { builtinModules: builtins } = require('module')
+const builtins = require('./builtin-modules.json')
 
 var scopedPackagePattern = new RegExp('^(?:@([^/]+?)[/])?([^/]+?)$')
 var exclusionList = [

package.json

@@ -11,6 +11,7 @@
     "@npmcli/template-oss": "4.28.1"
   },
   "scripts": {
+    "builtin-fixture": "node -e \"console.log(JSON.stringify(require('node:module').builtinModules))\" > ./lib/builtin-modules.json",
     "cov:test": "TAP_FLAGS='--cov' npm run test:code",
     "test:code": "tap ${TAP_FLAGS:-'--'} test/*.js",
     "test:style": "standard",

test/index.js

@@ -173,3 +173,20 @@ test('validate-npm-package-name', function () {
     validForOldPackages: true,
     warnings: ['name can no longer contain capital letters'] })
 })
+/*
+* This test will start failing if a newer version of node is used that adds new builtins.
+* That means it's time to update the list of builtins that this package knows about by running "npm run builtin-fixture"
+*/
+test('node builtins', function () {
+  const { builtinModules: nodeBuiltins } = require('node:module')
+  for (const builtin of nodeBuiltins) {
+    // some builtins are already invalid from other rules
+    if (!builtin.startsWith('_') && !builtin.includes('/') && !builtin.includes(':')) {
+      assert.deepStrictEqual(validate(builtin), {
+        validForNewPackages: false,
+        validForOldPackages: true,
+        warnings: [`${builtin} is a core module name`],
+      })
+    }
+  }
+})